Hi Isis devs, I see you use directly log4j without slf4j as facade. Have you discussed the usage of slf4j ?
On Thu, Jan 31, 2013 at 12:02 PM, <[email protected]> wrote: > Updated Branches: > refs/heads/master 999912453 -> c3f296997 > > > ISIS-320: Be more verbose when wicket page fails to render > > > Project: http://git-wip-us.apache.org/repos/asf/isis/repo > Commit: http://git-wip-us.apache.org/repos/asf/isis/commit/c3f29699 > Tree: http://git-wip-us.apache.org/repos/asf/isis/tree/c3f29699 > Diff: http://git-wip-us.apache.org/repos/asf/isis/diff/c3f29699 > > Branch: refs/heads/master > Commit: c3f2969979cb065953ee7e15b8aa85e4819be89c > Parents: 9999124 > Author: Jeroen van der Wal <[email protected]> > Authored: Thu Jan 31 12:01:46 2013 +0100 > Committer: Jeroen van der Wal <[email protected]> > Committed: Thu Jan 31 12:01:46 2013 +0100 > > ---------------------------------------------------------------------- > .../isis/viewer/wicket/ui/pages/PageAbstract.java | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > ---------------------------------------------------------------------- > > > > http://git-wip-us.apache.org/repos/asf/isis/blob/c3f29699/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstract.java > ---------------------------------------------------------------------- > diff --git > a/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstract.java > b/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstract.java > index c400f43..d4d59da 100644 > --- > a/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstract.java > +++ > b/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstract.java > @@ -38,6 +38,8 @@ import > org.apache.isis.viewer.wicket.ui.app.registry.ComponentFactoryRegistry; > import > org.apache.isis.viewer.wicket.ui.app.registry.ComponentFactoryRegistryAccessor; > import org.apache.isis.viewer.wicket.ui.pages.about.AboutPage; > import org.apache.isis.viewer.wicket.ui.pages.login.WicketSignInPage; > + > +import org.apache.log4j.Logger; > import org.apache.wicket.RestartResponseAtInterceptPageException; > import org.apache.wicket.markup.head.CssReferenceHeaderItem; > import org.apache.wicket.markup.head.IHeaderResponse; > @@ -58,6 +60,7 @@ import com.google.inject.name.Named; > */ > public abstract class PageAbstract extends WebPage { > > + private static Logger LOG = Logger.getLogger(PageAbstract.class); > > private static final long serialVersionUID = 1L; > > @@ -107,6 +110,8 @@ public abstract class PageAbstract extends WebPage { > addAboutLink(); > add(new Label(ID_PAGE_TITLE, > PageParameterNames.PAGE_TITLE.getStringFrom(pageParameters, > applicationName))); > } catch(RuntimeException ex) { > + > + LOG.error("Failed to construct page, going back to sign in > page", ex); > // hack for IE > getSession().invalidate(); > throw new > RestartResponseAtInterceptPageException(WicketSignInPage.class); > > -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com <http://jweekend.com/>
