[ 
https://issues.apache.org/jira/browse/ISIS-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13726196#comment-13726196
 ] 

ASF subversion and git services commented on ISIS-482:
------------------------------------------------------

Commit 54ad0660f445658c86a428d1a89d09ffe8bd9c25 in branch refs/heads/master 
from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=54ad066 ]

ISIS-482: applying patch from Oscar Bou

Author: o....@gesconsultor.com

Signed-off-by: Dan Haywood <danhayw...@apache.org>

                
> Allow as "choices" return type any descendant of "Collection"
> -------------------------------------------------------------
>
>                 Key: ISIS-482
>                 URL: https://issues.apache.org/jira/browse/ISIS-482
>             Project: Isis
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: core-1.3.0
>            Reporter: Oscar Bou
>            Assignee: Dan Haywood
>         Attachments: patch.diff
>
>
> Current implementation only allows to return a List with the choices for a 
> given property, action or action parameter.
> It should be improved to allow to return any descendant of 
> java.util.Collection.
> All these cases should be valid:
>          class Customer {
>              @SuppressWarnings("unused")
>             public void someAction(final int x, final long y, final long z) {
>             }
>  
>              @SuppressWarnings("unused")
>             public Collection<Integer> choices0SomeAction() {
>                  return Collections.emptyList();
>              }
>  
>              @SuppressWarnings("unused")
>              public List<Long> choices1SomeAction() {
>                  return Collections.emptyList();
>              }
>             @SuppressWarnings("unused")
>             public Set<Long> choices2SomeAction() {
>                 return Collections.emptySet();
>             }
>          }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to