Really nice. With those validations the power and expressiveness of the Isis domain classes will be really high!
I'll take a look at the implementation classes you mention on the ticket, and, specially, to the commit when available on git. Regarding the constraint groups specification on JSR-349 [1], it's a really powerful feature. If Apache Isis ignore the groups that must be validated, we would force while persisting() the entity that all constraints are ok, while only the groups defined by the user should be validated. Another problem it could introduced would be with database generated ids [2] annotated with @NotNull. Instead, I think that Isis could follow an approach similar to the ones on the specification for JPA 2 [3] and/or Hibernate [4]. For the former, similar properties could be specify on the isis.properties file (or another one related to the object persistor), and for the former the hability to register validation listerners on the Isis lifecycle. Hope this helps, Oscar [1] http://docs.jboss.org/hibernate/stable/validator/reference/en-US/html_single/#chapter-groups [2] http://beanvalidation.org/proposals/BVAL-234/ [3] http://docs.jboss.org/hibernate/stable/validator/reference/en-US/html_single/#d0e5006 [4] http://docs.jboss.org/hibernate/stable/validator/reference/en-US/html_single/#validator-checkconstraints-orm-hibernateevent El 13/08/2013, a las 09:18, Dan Haywood <[email protected]> escribió: > On 6 August 2013 18:49, GESCONSULTOR - Óscar Bou > <[email protected]>wrote: > >> For the last part of the email (property validation) I was just looking >> again at the JSR-349 specification, whose last version has just been >> approved and incorporated to Java 7. >> >> Seems that the reference implementation (Hibernate Validator) is Apache >> licensed [1]. >> >> How should it be used within an Apache Isis domain implementation? >> >> I've raised a new ticket ISIS-491 [2] for this; the comments sketch out > the implementation. > > > >> >> >> [1] >> http://docs.jboss.org/hibernate/stable/validator/reference/en-US/html_single/ >> >> [2] https://issues.apache.org/jira/browse/ISIS-491
