[
https://issues.apache.org/jira/browse/ISIS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765951#comment-13765951
]
Dan Haywood commented on ISIS-520:
----------------------------------
This change introduced a regression.. running the app as a regular webserver
(eg in Tomcat), causes an infinite loop if the isis.deploymentType is not in
the isis.properties.
This was not the intended behaviour.
The change now implemented means that:
- if run under Tomcat, then honours the configurationType as configured in
web.xml (either 'development' or 'deployment') per Wicket standards
- if run via org.apache.isis.WebServer, then honours --type (either SERVER or
SERVER_PROTOTYPE), but if the --type is omitted then defaults to
SERVER_PROTOTYPE *even if* the web.xml says configuration is 'deployment'
> Allow wicket viewer to be run in either development or deployment mode by
> passing in the Isis --type cmd line arg.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: ISIS-520
> URL: https://issues.apache.org/jira/browse/ISIS-520
> Project: Isis
> Issue Type: Improvement
> Components: Viewer: Wicket
> Affects Versions: viewer-wicket-1.2.0
> Reporter: Dan Haywood
> Assignee: Dan Haywood
> Fix For: viewer-wicket-1.3.0
>
>
> Isis' deploymentType configuration parameter declares EXPLORATION,
> PROTOTYPING and SERVER as three modes of operation; broadly speaking,
> "SERVER" corresponds to production.
> Wicket, meanwhile, has its configurationType which takes values of
> "DEVELOPMENT" or "DEPLOYMENT".
> Currently the Wicket viewer reads the Wicket "configurationType" init-param,
> and infers the Isis deploymentType from it.
> However, it would also be useful to go the other way, so that running the app
> through the org.apache.isis.WebServer (ie jetty) would honour the --type (-t)
> cmd line arg.
> For simplicity, suggest:
> - Isis SERVER = Wicket DEPLOYMENT mode
> - Isis anything else = Wicket DEVELOPMENT mode
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
