[ 
https://issues.apache.org/jira/browse/ISIS-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779863#comment-13779863
 ] 

Martin Grigorov commented on ISIS-547:
--------------------------------------

--- 
i/wicket-core/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
+++ 
w/wicket-core/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
@@ -435,7 +435,8 @@ public class WicketFilter implements Filter
                {
                        // #destroy() might not be called by the web container 
when #init() fails,
                        // so destroy now
-                       log.warn("initialization failed, destroying now");
+                       log.error(String.format("The initialization of an 
application with name '%s' has failed",
+                                       filterConfig.getFilterName()), e);
 
                        try
                        {
@@ -443,7 +444,7 @@ public class WicketFilter implements Filter
                        }
                        catch (Exception destroyException)
                        {
-                               log.warn("Unable to destroy after 
initialization failure", destroyException);
+                               log.error("Unable to destroy after 
initialization failure", destroyException);
                        }

The log level of the message should be an ERROR.
                
> Provide better error logging from the Wicket applicaiton init() method if 
> Isis fails to boot.
> ---------------------------------------------------------------------------------------------
>
>                 Key: ISIS-547
>                 URL: https://issues.apache.org/jira/browse/ISIS-547
>             Project: Isis
>          Issue Type: Improvement
>          Components: Viewer: Wicket
>    Affects Versions: viewer-wicket-1.2.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: viewer-wicket-1.3.0
>
>
> This is a work-around for the fact that the Wicket framework's WicketFilter, 
> that calls Application#init(), does not log any runtime exception that is 
> thrown.
> For example, if a missing JDBC driver has not been configured, then this fact 
> is never logged explicitly.
> The fix is to catch the runtime exception in the IsisWicketApplicaiton, and 
> have it log before propogating the exception up to its caller (WicketFilter).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to