Well, we already have this in dependency in the actions (@ActionLayout(cssClassFa="...")), so in a sense that decision's already been taken.
My view is that annotations/metadata that pertains to the domain itself (eg @Disabled, @RegEx) should be generic, but we don't want to unnecessarily abstract away in the UI layer (ie the @XxxLayout annotations). Two pragmatic reasons: (a) we would need to maintain some sort of mapping, and (b) it makes things less grokkable for newcomers. That said, I do think we should support other icon providers. icons8 is one, certainly, and so is glyphicons. In the future I foresee us introducing "cssClassIcons8" and "cssClassGlyph", for example, as new attributes of @ActionLayout et al. Does that make sense? Dan On 12 December 2014 at 11:34, GESCONSULTOR <[email protected]> wrote: > > Is not this too concrete? > > Could it be specified by means of a more generic mechanism? > > I find too specific to have an annotation property for a concrete set of > icons. There are others currently also used (like icons8, etc) that could > be also referred. > > Perhaps a mechanism a bit more generic could instead be used? Or at least > an annotation field name not referring on its name the "font awesome" > initials? > > HTH, > > Oscar > > > > El 12/12/2014, a las 11:13, Dan Haywood (JIRA) <[email protected]> > escribió: > > > > Dan Haywood created ISIS-974: > > -------------------------------- > > > > Summary: Provide the ability to associate font-awesome icons > with properties > > Key: ISIS-974 > > URL: https://issues.apache.org/jira/browse/ISIS-974 > > Project: Isis > > Issue Type: Improvement > > Components: Core, Viewer: Wicket > > Affects Versions: core-1.7.0, viewer-wicket-1.7.0 > > Reporter: Dan Haywood > > Assignee: Dan Haywood > > Priority: Minor > > Fix For: viewer-wicket-1.9.0, core-1.9.0 > > > > > > ie as per http://fortawesome.github.io/Font-Awesome/examples/#bootstrap > > > > using: > > > > @PropertyLayout( > > cssClassFa="fa fa-fw fa-envelope-o" > > ) > > public String getEmailAddress() { ... } > > > > etc. > > > > > > > > -- > > This message was sent by Atlassian JIRA > > (v6.3.4#6332) >
