[
https://issues.apache.org/jira/browse/ISIS-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263566#comment-14263566
]
Dan Haywood commented on ISIS-984:
----------------------------------
[~mgrigorov] - two reasons. First, legacy. Second, because it is dynamic, the
icon can change based on the object's state, see eg
https://github.com/apache/isis/blob/b3e936c9aae28754fb46c2df52b1cb9b023f9ab8/example/application/todoapp/dom/src/main/java/dom/todo/ToDoItem.java#L151
and
https://github.com/danhaywood/isis-app-petclinic/blob/6f92a8ee8e76696d005da2a8b7a746444d017546/dom/src/main/java/dom/pets/Pet.java#L49.
The value is interpreted initially as a suffix (eg "ToDoItem-done"), else as
the full value (eg "Dog"). We search for various file types, eg "Dog.png",
"Dog.jpg" etc.
> Make it possible to use custom icons, not only FontAwesome ones
> ---------------------------------------------------------------
>
> Key: ISIS-984
> URL: https://issues.apache.org/jira/browse/ISIS-984
> Project: Isis
> Issue Type: Improvement
> Components: Viewer: Wicket
> Affects Versions: viewer-wicket-1.8.0
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: viewer-wicket-1.9.0
>
>
> See discussion at: http://markmail.org/message/nhm7eflnrru2rvcr
> The idea is to replace ActionLayout#cssClassFa and
> ActionLayout#cssClassFaPosition with ActionLayout#icon.
> Icon will be an interface/abstract class.
> Isis will provide impl for FontAwesome.
> Each application will be able to provide its own impl for any icon type it
> needs/wants to use (e.g. http://icons8.com/, http://glyphsearch.com/,
> http://glyphsearch.com/, etc.).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
