I've raised ISIS-1004 for this, should be easy enough to fix. I think it'd be better to implement this use case without resorting to the lifecycle hooks, however, eg with some external optional service. I've raised ISIS-1005 for this, opinions welcome
Thx Dan On 8 January 2015 at 09:36, GESCONSULTOR - Óscar Bou <[email protected] > wrote: > Hi all, > > I’m in the process of upgrading to the latest Apache Isis snapshot our > codebase. > > I’ve entered an infinite recursion when using the updating() platform’s > method: > > @PersistenceCapable(identityType = IdentityType.DATASTORE) > @DatastoreIdentity(strategy = IdGeneratorStrategy.IDENTITY) > @Inheritance(strategy = InheritanceStrategy.SUBCLASS_TABLE/* > * , > customStrategy = > * > "complete-table" > */) > @Version(strategy = VersionStrategy.VERSION_NUMBER, extensions = { > @Extension(vendorName = "datanucleus", key = "field-name", value = > "versionField") }) > public abstract class AbstractXMSDomainObject extends > org.apache.isis.applib.AbstractDomainObject implements DomainObject, > Comparable<AbstractXMSDomainObject> { > > … > public void updating() { > this.setDateUpdated(Clock.getTimeAsDateTime().toDate()); > this.setUpdatedByUser(this.domainFactoryService.currentUserName()); > } > … > } > > > This was running smoothly with the previous 1.6.0-SNAPSHOT we were using. > > The exception log is the following: > > > […] > > at > org.datanucleus.api.jdo.JDOCallbackHandler.preDirty(JDOCallbackHandler.java:262) > at > org.datanucleus.state.JDOStateManager.updateField(JDOStateManager.java:2007) > at > org.datanucleus.state.JDOStateManager.setObjectField(JDOStateManager.java:1935) > at > com.xms.framework.api.domain.model.isis.AbstractXMSDomainObject.setDateUpdated(AbstractXMSDomainObject.java) > at > com.xms.framework.api.domain.model.isis.AbstractXMSDomainObject.updating(AbstractXMSDomainObject.java:284) > at sun.reflect.GeneratedMethodAccessor16.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:483) > at > org.apache.isis.core.commons.lang.MethodExtensions.invoke(MethodExtensions.java:53) > at > org.apache.isis.core.commons.lang.MethodExtensions.invoke(MethodExtensions.java:47) > at > org.apache.isis.core.commons.lang.MethodUtil.invoke(MethodUtil.java:35) > at > org.apache.isis.core.metamodel.adapter.ObjectAdapter$InvokeUtils.invokeAll(ObjectAdapter.java:342) > at > org.apache.isis.core.metamodel.facets.object.callbacks.update.UpdatingCallbackFacetViaMethod.invoke(UpdatingCallbackFacetViaMethod.java:67) > at > org.apache.isis.core.metamodel.facets.object.callbacks.CallbackFacet$Util.callCallback(CallbackFacet.java:44) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer$4.run(FrameworkSynchronizer.java:256) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer$8.call(FrameworkSynchronizer.java:350) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer$8.call(FrameworkSynchronizer.java:346) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer.withLogging(FrameworkSynchronizer.java:335) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer.withLogging(FrameworkSynchronizer.java:346) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer.preDirtyProcessingFor(FrameworkSynchronizer.java:229) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener$4.doRun(IsisLifecycleListener.java:111) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener$RunnableAbstract.run(IsisLifecycleListener.java:206) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener.withLogging(IsisLifecycleListener.java:185) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener.preDirty(IsisLifecycleListener.java:107) > at > org.datanucleus.api.jdo.JDOCallbackHandler.preDirty(JDOCallbackHandler.java:262) > at > org.datanucleus.state.JDOStateManager.updateField(JDOStateManager.java:2007) > at > org.datanucleus.state.JDOStateManager.setObjectField(JDOStateManager.java:1935) > at > com.xms.framework.api.domain.model.isis.AbstractXMSDomainObject.setDateUpdated(AbstractXMSDomainObject.java) > at > com.xms.framework.api.domain.model.isis.AbstractXMSDomainObject.updating(AbstractXMSDomainObject.java:284) > at sun.reflect.GeneratedMethodAccessor16.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:483) > at > org.apache.isis.core.commons.lang.MethodExtensions.invoke(MethodExtensions.java:53) > at > org.apache.isis.core.commons.lang.MethodExtensions.invoke(MethodExtensions.java:47) > at > org.apache.isis.core.commons.lang.MethodUtil.invoke(MethodUtil.java:35) > at > org.apache.isis.core.metamodel.adapter.ObjectAdapter$InvokeUtils.invokeAll(ObjectAdapter.java:342) > at > org.apache.isis.core.metamodel.facets.object.callbacks.update.UpdatingCallbackFacetViaMethod.invoke(UpdatingCallbackFacetViaMethod.java:67) > at > org.apache.isis.core.metamodel.facets.object.callbacks.CallbackFacet$Util.callCallback(CallbackFacet.java:44) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer$4.run(FrameworkSynchronizer.java:256) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer$8.call(FrameworkSynchronizer.java:350) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer$8.call(FrameworkSynchronizer.java:346) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer.withLogging(FrameworkSynchronizer.java:335) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer.withLogging(FrameworkSynchronizer.java:346) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer.preDirtyProcessingFor(FrameworkSynchronizer.java:229) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener$4.doRun(IsisLifecycleListener.java:111) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener$RunnableAbstract.run(IsisLifecycleListener.java:206) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener.withLogging(IsisLifecycleListener.java:185) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener.preDirty(IsisLifecycleListener.java:107) > at > org.datanucleus.api.jdo.JDOCallbackHandler.preDirty(JDOCallbackHandler.java:262) > at > org.datanucleus.state.JDOStateManager.updateField(JDOStateManager.java:2007) > at > org.datanucleus.state.JDOStateManager.setObjectField(JDOStateManager.java:1935) > at > com.xms.framework.api.domain.model.isis.AbstractXMSDomainObject.setDateUpdated(AbstractXMSDomainObject.java) > at > com.xms.framework.api.domain.model.isis.AbstractXMSDomainObject.updating(AbstractXMSDomainObject.java:284) > at sun.reflect.GeneratedMethodAccessor16.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:483) > at > org.apache.isis.core.commons.lang.MethodExtensions.invoke(MethodExtensions.java:53) > at > org.apache.isis.core.commons.lang.MethodExtensions.invoke(MethodExtensions.java:47) > at > org.apache.isis.core.commons.lang.MethodUtil.invoke(MethodUtil.java:35) > at > org.apache.isis.core.metamodel.adapter.ObjectAdapter$InvokeUtils.invokeAll(ObjectAdapter.java:342) > at > org.apache.isis.core.metamodel.facets.object.callbacks.update.UpdatingCallbackFacetViaMethod.invoke(UpdatingCallbackFacetViaMethod.java:67) > at > org.apache.isis.core.metamodel.facets.object.callbacks.CallbackFacet$Util.callCallback(CallbackFacet.java:44) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer$4.run(FrameworkSynchronizer.java:256) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer$8.call(FrameworkSynchronizer.java:350) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer$8.call(FrameworkSynchronizer.java:346) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer.withLogging(FrameworkSynchronizer.java:335) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer.withLogging(FrameworkSynchronizer.java:346) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer.preDirtyProcessingFor(FrameworkSynchronizer.java:229) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener$4.doRun(IsisLifecycleListener.java:111) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener$RunnableAbstract.run(IsisLifecycleListener.java:206) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener.withLogging(IsisLifecycleListener.java:185) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener.preDirty(IsisLifecycleListener.java:107) > at > org.datanucleus.api.jdo.JDOCallbackHandler.preDirty(JDOCallbackHandler.java:262) > at > org.datanucleus.state.JDOStateManager.updateField(JDOStateManager.java:2007) > at > org.datanucleus.state.JDOStateManager.setObjectField(JDOStateManager.java:1935) > at > com.xms.framework.api.domain.model.isis.AbstractXMSDomainObject.setDateUpdated(AbstractXMSDomainObject.java) > at > com.xms.framework.api.domain.model.isis.AbstractXMSDomainObject.updating(AbstractXMSDomainObject.java:284) > at sun.reflect.GeneratedMethodAccessor16.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:483) > at > org.apache.isis.core.commons.lang.MethodExtensions.invoke(MethodExtensions.java:53) > at > org.apache.isis.core.commons.lang.MethodExtensions.invoke(MethodExtensions.java:47) > at > org.apache.isis.core.commons.lang.MethodUtil.invoke(MethodUtil.java:35) > at > org.apache.isis.core.metamodel.adapter.ObjectAdapter$InvokeUtils.invokeAll(ObjectAdapter.java:342) > at > org.apache.isis.core.metamodel.facets.object.callbacks.update.UpdatingCallbackFacetViaMethod.invoke(UpdatingCallbackFacetViaMethod.java:67) > at > org.apache.isis.core.metamodel.facets.object.callbacks.CallbackFacet$Util.callCallback(CallbackFacet.java:44) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer$4.run(FrameworkSynchronizer.java:256) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer$8.call(FrameworkSynchronizer.java:350) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer$8.call(FrameworkSynchronizer.java:346) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer.withLogging(FrameworkSynchronizer.java:335) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer.withLogging(FrameworkSynchronizer.java:346) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer.preDirtyProcessingFor(FrameworkSynchronizer.java:229) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener$4.doRun(IsisLifecycleListener.java:111) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener$RunnableAbstract.run(IsisLifecycleListener.java:206) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener.withLogging(IsisLifecycleListener.java:185) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener.preDirty(IsisLifecycleListener.java:107) > at > org.datanucleus.api.jdo.JDOCallbackHandler.preDirty(JDOCallbackHandler.java:262) > at > org.datanucleus.state.JDOStateManager.updateField(JDOStateManager.java:2007) > at > org.datanucleus.state.JDOStateManager.setObjectField(JDOStateManager.java:1935) > at > com.xms.framework.api.domain.model.isis.AbstractXMSDomainObject.setDateUpdated(AbstractXMSDomainObject.java) > at > com.xms.framework.api.domain.model.isis.AbstractXMSDomainObject.updating(AbstractXMSDomainObject.java:284) > at sun.reflect.GeneratedMethodAccessor16.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:483) > at > org.apache.isis.core.commons.lang.MethodExtensions.invoke(MethodExtensions.java:53) > at > org.apache.isis.core.commons.lang.MethodExtensions.invoke(MethodExtensions.java:47) > at > org.apache.isis.core.commons.lang.MethodUtil.invoke(MethodUtil.java:35) > at > org.apache.isis.core.metamodel.adapter.ObjectAdapter$InvokeUtils.invokeAll(ObjectAdapter.java:342) > at > org.apache.isis.core.metamodel.facets.object.callbacks.update.UpdatingCallbackFacetViaMethod.invoke(UpdatingCallbackFacetViaMethod.java:67) > at > org.apache.isis.core.metamodel.facets.object.callbacks.CallbackFacet$Util.callCallback(CallbackFacet.java:44) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer$4.run(FrameworkSynchronizer.java:256) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer$8.call(FrameworkSynchronizer.java:350) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer$8.call(FrameworkSynchronizer.java:346) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer.withLogging(FrameworkSynchronizer.java:335) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer.withLogging(FrameworkSynchronizer.java:346) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.FrameworkSynchronizer.preDirtyProcessingFor(FrameworkSynchronizer.java:229) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener$4.doRun(IsisLifecycleListener.java:111) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener$RunnableAbstract.run(IsisLifecycleListener.java:206) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener.withLogging(IsisLifecycleListener.java:185) > at > org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener.preDirty(IsisLifecycleListener.java:107)
