Hi Dan, I still don't understand how the tiny change of a boolean in in Java class [1] adds ASM in the classpath. It is either in the classpath and everything works or it is not there and usage at runtime fails with ClassNotFoundException. It seems ASM is in the classpath already because everything was working fine so far. With changing the boolean flag to true wicket-ioc just started using it, but didn't introduce it!
I see two possible solutions: 1) use serializable proxies for Guice beans and make sure only ASM 4.x is in the classpath since it is required by DataNucleus. AFAIK ASM tries to keep its APIs stable between major releases so there is no problem if wicket-ioc uses ASM 4.x. Wicket 7.x uses ASM 5.x for better Java 8 support and again there were no changes in wicket-ioc classes for this update. 2) make all Guice beans in Isis serializable This will solve the issue that led to ISIS-1062 but if an application adds custom Guice beans then they have to make sure they are serializable IMO 1) is better. Martin 1. https://git-wip-us.apache.org/repos/asf?p=isis.git;a=commitdiff;h=f800860;hp=55e569c9bbadddd3de1b5e6e703181400424658d (this is the revert)
