[ 
https://issues.apache.org/jira/browse/ISIS-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14483102#comment-14483102
 ] 

Martin Grigorov commented on ISIS-1085:
---------------------------------------

The default position is LEFT [1]. So if RIGHT is expected then there should be 
an assert, yes.

1. 
https://github.com/apache/isis/blob/867188b865edaae77c4999c6059f79f0bc79b096/core/applib/src/main/java/org/apache/isis/applib/annotation/ActionLayout.java#L73

> Add cssClassFa to DomainObjectLayout
> ------------------------------------
>
>                 Key: ISIS-1085
>                 URL: https://issues.apache.org/jira/browse/ISIS-1085
>             Project: Isis
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: core-1.8.0
>            Reporter: Jörg Rade
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: 1.9.0
>
>         Attachments: ScreenShot 090 SALOG 2.5.6.0 -_ 2.6.0.0-SNAPSHOT - 
> Mozilla Firefox.png, ScreenShot 091 IfcMgmt - Bndtools - 
> sdm-dom_src_main_java_sdm_dom_Application.java - Eclipse SDK.png
>
>
> * @CssClassFa is deprecated but is able to decorate DomainObjects with font 
> awesome icons.
> * this feature does not work reliably (in my app it works with 11 out 13 
> classes).
> * @DomainObjectLayout does not support cssClassFa currently
> # add attribute to @DomainObjectLayout, move/copy implementation
> # eventually fix bug
> # eventually remove deprecated annotation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to