[ 
https://issues.apache.org/jira/browse/ISIS-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063757#comment-15063757
 ] 

ASF subversion and git services commented on ISIS-1224:
-------------------------------------------------------

Commit 2eaf24216586112ef61b734fdf4940c6fb6abf52 in isis's branch 
refs/heads/ISIS-1224-wicket6-backport from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2eaf242 ]

ISIS-1224 Upgrade select2 from v3.5.2 to v4

In ActionParametersFormPanel do not repaint the complete 
ReferencePanel/ValueChoicesSelect2Panel but just its Select2 child component.
It the complete parent is repainted then Select2 JS widget somehow looses 
information about the parent DOM element and renders the drop-down as orphan, 
i.e. CSS: position:absolute; left:0; top:0;

If only the Select2Choice element is repainted then it just sends its new 
values as JSON back and doesn't recreate the complete widget but just its 
options.

The flow is:
1) the user types something in another field
2) the user clicks on Select2
2.1) the 'change' JS event for the first field fires Ajax call
2.1.1) with the old behavior the Ajax response repaints the whole ReferencePanel
2.1.2) with the new behavior the Ajax response repaints only the Select2 options
2.2) the click on Select2 opens its drop-down
2.3) the Ajax response for 2.1) comes and closes Select2 to update it
3) with the new behavior the user has to click second time to show the 
drop-down again, but at least its CSS position is correct


> Upgrade select2 from v3.5.2 to v4 (though this DOESN'T address the floating 
> drop-down problem)
> ----------------------------------------------------------------------------------------------
>
>                 Key: ISIS-1224
>                 URL: https://issues.apache.org/jira/browse/ISIS-1224
>             Project: Isis
>          Issue Type: Bug
>            Reporter: Dan Haywood
>            Assignee: Martin Grigorov
>             Fix For: 1.11.0
>
>
> This ticket supercedes ISIS-1020 (where the problem was originally reported); 
> it is dependent upon ISIS-1223.
> Original screencast to demonstrate in Estatio: 
> https://drive.google.com/file/d/0B2jd2Sl73mDBZ0lqYUhtVjVRamc/view?usp=sharing
> This is reproducible in both IE11 and Chrome.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to