[
https://issues.apache.org/jira/browse/ISIS-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069800#comment-15069800
]
ASF subversion and git services commented on ISIS-1193:
-------------------------------------------------------
Commit f3ed6994d8239be195954507a4cfe2c4802fca31 in isis's branch
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f3ed699 ]
ISIS-1193: shouldn't return a 404 if void action, instead 200 (per RO spec).
The issue was because of the ContentNegotationServiceXRoDomainType expecting
there to always be an object from an action invocation, and throwing a 404
otherwise. Changed around so that this logic only fires if there is a mime
type parameter specifying the x-ro-domain-type (ie brought that checking
forward).
Also:
- fixed rendering of void action result for the RO Spec v1.0 renderer, to
include the "resulttype" json-prop.
> void actions return 404 Not Found when called through restful viewer
> --------------------------------------------------------------------
>
> Key: ISIS-1193
> URL: https://issues.apache.org/jira/browse/ISIS-1193
> Project: Isis
> Issue Type: Bug
> Components: Core: Viewer: RestfulObjects
> Affects Versions: 1.9.0
> Reporter: Jeroen van der Wal
> Assignee: Dan Haywood
> Fix For: 1.11.0
>
>
> We have method with this signature:
> @Action(semantics = SemanticsOf.IDEMPOTENT)
> public void putTax(
> final String atPath,
> final String reference,
> final String name,
> final String description,
> final @Parameter(optionality = Optionality.OPTIONAL) String
> externalReference,
> final BigDecimal ratePercentage,
> final LocalDate rateStartDate,
> final @Parameter(optionality = Optionality.OPTIONAL) String
> rateExternalReference) {
> ...
> }
> When putting a valid payload on the endpoint the viewer returns a 404 Not
> Found. Since the payload is processed correctly expect a 200 OK.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
