Dan Haywood created ISIS-1388:
---------------------------------
Summary: Order of fields (as shown by column ordering) should be
more predictable.
Key: ISIS-1388
URL: https://issues.apache.org/jira/browse/ISIS-1388
Project: Isis
Issue Type: Bug
Components: Core
Affects Versions: 1.12.1
Reporter: Dan Haywood
Assignee: Dan Haywood
Fix For: 1.13.0
At the moment it can be hard to predict, because the BS3Grid is traversed by
type, eg:
{code}
private void traverseCols(final Grid.Visitor visitor, final BS3Row bs3Row) {
final BS3Grid.Visitor bs3Visitor = asBs3Visitor(visitor);
final List<BS3RowContent> cols = bs3Row.getCols();
for (BS3RowContent rowContent : Lists.newArrayList(cols)) {
rowContent.setOwner(bs3Row);
if(rowContent instanceof BS3Col) {
final BS3Col bs3Col = (BS3Col) rowContent;
bs3Visitor.preVisit(bs3Col);
bs3Visitor.visit(bs3Col);
traverseDomainObject(bs3Col, visitor);
traverseTabGroups(bs3Col, visitor);
traverseActions(bs3Col, visitor);
traverseFieldSets(bs3Col, visitor);
traverseCollections(bs3Col, visitor);
traverseRows(bs3Col, visitor);
bs3Visitor.postVisit(bs3Col);
} else if (rowContent instanceof BS3ClearFix) {
final BS3ClearFix bs3ClearFix = (BS3ClearFix) rowContent;
bs3Visitor.visit(bs3ClearFix);
} else {
throw new IllegalStateException(
"Unrecognized implementation of BS3RowContent, " +
rowContent);
}
}
}
{code}
Instead, if it were traversed by element order, then the ordering of properties
would be more predictable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
