[
https://issues.apache.org/jira/browse/ISIS-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291040#comment-15291040
]
ASF subversion and git services commented on ISIS-1406:
-------------------------------------------------------
Commit 7456588834a18ff4b47e59af93e1ccaa29912457 in isis's branch
refs/heads/ISIS-1406 from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7456588 ]
ISIS-1406: lots more refactoring around IsisConfiguration and
IsisConfigurationBuilder.
specifically:
- simplified IsisConfigurationBuilder, now a single class (rather than an
interface with 4 different impls, only 2 of which were used).
- removed IsisRunner, so that the command line options are now a responsibility
of the IsisConfigurationBuilder
- IsisConfigurationBuilder is passed from o.a.i.WebServer to
IsisWicketApplication (not just the "primers"
- removed OptionValidator, wasn't being used
- FacetFactoryAbstract responsible for providing IsisConfiguration to all
subclass impls
- InstallerLookup simplified, no longer responsible for appending to the
IsisConfigurationBuilder
- InstallerAbstract impls now all have the IsisConfiguration injected into them
(constructor injection).
- removed duplication between IsisWebAppBootstrapper and IsisWicketApplication
As of this commit the app runs, but the fixtures are not being automatically
installed.
> Refactor IsisConfigurationDefault and the metamodel.ConfigurationService into
> an internal domain service
> --------------------------------------------------------------------------------------------------------
>
> Key: ISIS-1406
> URL: https://issues.apache.org/jira/browse/ISIS-1406
> Project: Isis
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.12.1
> Reporter: Dan Haywood
> Assignee: Dan Haywood
> Priority: Minor
> Fix For: 1.13.0
>
>
> Moving towards CDI-style injection, removing our home-grown stuff.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
