[
https://issues.apache.org/jira/browse/ISIS-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333468#comment-15333468
]
ASF subversion and git services commented on ISIS-1441:
-------------------------------------------------------
Commit 364e5b9b64d6e831fecaec559ef649029c746ede in isis's branch
refs/heads/ISIS-1427 from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=364e5b9 ]
ISIS-1441: removes AuthenticationManagerStandardForDfltRuntime, instead use
AuthenticationManagerStandard.
The supporting classes move from isis-core-runtime to isis-core-metamodel.
Because the Authenticator subclasses relied on DeploymentType (only available
in the isis-core-runtime), these instead depend on DeploymentCategory (in
isis-core-metamodel).
This also includes a minor refactoring in the closeSession stuff... previously
we called closeSession on AuthenticationManagerStandardForDfltRuntime, that in
turn called IsisSessionFactory#closeSession() in order to clear the threadlocal
holding the current session. However, IsisSessionFactory is part of
isis-core-runtime so this design doesn't work. However, there is only one
caller of closeSession, namely UserResourceServerside (the RO viewer). The
refactoring is therefore easy enough... just have UserResourceServerside make
the call to IsisSessionFactory.
> Remove subclass of AuthenticationManagerStandard in isis-core-runtime.
> ----------------------------------------------------------------------
>
> Key: ISIS-1441
> URL: https://issues.apache.org/jira/browse/ISIS-1441
> Project: Isis
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.12.2
> Reporter: Dan Haywood
> Assignee: Dan Haywood
> Priority: Minor
> Fix For: 1.13.0
>
>
> Simplifying the codebase; with a small amount of refactoring, can move the
> classes to isis-core-metamodel and reduce the class hierarchy.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
