[ 
https://issues.apache.org/jira/browse/ISIS-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15472034#comment-15472034
 ] 

ASF subversion and git services commented on ISIS-1481:
-------------------------------------------------------

Commit bab40dc25d00761bd447a0aaa7305f4efea7044d in isis's branch 
refs/heads/maint-1.13.1 from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bab40dc ]

ISIS-1481: ensures that all methods of AuthenticatedWebSession are 
synchronized, in order to avoid a race conditions, eg in SessionLoggingService 
when authenicating.


> Duplicate PK exception for SessoinLogEntry (isisaddons implementation of 
> SessionLoggingService) due to race condition.
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-1481
>                 URL: https://issues.apache.org/jira/browse/ISIS-1481
>             Project: Isis
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.13.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: 1.13.1
>
>
> for example:
> {code}
> java.sql.BatchUpdateException: Violation of PRIMARY KEY constraint 
> 'SessionLogEntry_PK'. Cannot insert duplicate key in object 
> 'isissessionlogger.SessionLogEntry'. The duplicate key value is (1379530416).
>         at 
> org.datanucleus.api.jdo.NucleusJDOHelper.getJDOExceptionForNucleusException(NucleusJDOHelper.java:543)
>         at 
> org.datanucleus.api.jdo.JDOPersistenceManager.flush(JDOPersistenceManager.java:2070)
>         at 
> org.apache.isis.core.runtime.system.persistence.PersistenceSession.executeCommands(PersistenceSession.java:1255)
>         at 
> org.apache.isis.core.runtime.system.persistence.PersistenceSession.execute(PersistenceSession.java:1247)
>         at 
> org.apache.isis.core.runtime.system.transaction.IsisTransaction.doFlush(IsisTransaction.java:378)
>         at 
> org.apache.isis.core.runtime.system.transaction.IsisTransaction.preCommit(IsisTransaction.java:419)
>         at 
> org.apache.isis.core.runtime.system.transaction.IsisTransactionManager.endTransaction(IsisTransactionManager.java:344)
>         at 
> org.apache.isis.core.runtime.system.transaction.IsisTransactionManager.executeWithinTransaction(IsisTransactionManager.java:145)
>         at 
> org.apache.isis.core.runtime.system.transaction.IsisTransactionManager.executeWithinTransaction(IsisTransactionManager.java:133)
>         at 
> org.apache.isis.core.runtime.system.persistence.PersistenceSession.makePersistentInTransaction(PersistenceSession.java:1102)
>         at 
> org.apache.isis.core.runtime.services.persistsession.PersistenceSessionServiceInternalDefault.makePersistent(PersistenceSessionServiceInternalDefault.java:83)
>         at 
> org.apache.isis.core.metamodel.services.repository.RepositoryServiceInternalDefault.persist(RepositoryServiceInternalDefault.java:96)
>         at 
> org.apache.isis.core.metamodel.services.container.DomainObjectContainerDefault.persistIfNotAlready(DomainObjectContainerDefault.java:365)
>         at 
> org.apache.isis.applib.AbstractContainedObject.persistIfNotAlready(AbstractContainedObject.java:574)
>         at 
> org.isisaddons.module.sessionlogger.dom.SessionLoggingServiceDefault.log(SessionLoggingServiceDefault.java:42)
>         at 
> org.apache.isis.viewer.wicket.viewer.integration.wicket.AuthenticatedWebSessionForIsis$1.run(AuthenticatedWebSessionForIsis.java:180)
>         at 
> org.apache.isis.core.runtime.system.session.IsisSessionFactory$1.call(IsisSessionFactory.java:316)
>         at 
> org.apache.isis.core.runtime.system.session.IsisSessionFactory$1.call(IsisSessionFactory.java:313)
>         at 
> org.apache.isis.core.runtime.system.session.IsisSessionFactory.doInSession(IsisSessionFactory.java:347)
>         ... 60 more
> {code}
> ||sessionId||causedBy||loginTimestamp||logoutTimestamp||user||
> |1379530416|NULL|2016-09-07 10:14:47.5690000|NULL|[email protected]|
> Here's some more:
> {code}
> 11:46:37,702 [WebRequestCycleForIsis        ] Unable to obtain 
> exceptionRecognizers (no session), will be treated as unrecognized exception
> org.apache.wicket.protocol.http.PageExpiredException: Page with id '8' has 
> expired.
> 11:48:11,808 [PersistenceSession            ] close: failed to close JDO 
> persistenceManager; continuing to avoid memory leakage
> 07-Sep-2016 11:48:09.973 WARNING 
> [ContainerBackgroundProcessor[StandardEngine[Catalina]]] 
> org.apache.catalina.core.StandardContext.backgroundProcess Exception 
> processing manager org.apache.catalina.session.StandardManager[/estatioprod] 
> background process
>  java.lang.IllegalStateException: No service of type class 
> org.apache.isis.applib.services.command.CommandContext is available on this
>         at 
> org.apache.isis.core.runtime.services.ServiceInstantiator$2.invoke(ServiceInstantiator.java:217)
>         at 
> org.apache.isis.applib.services.command.CommandContext_$$_jvst9b7_2.getCommand(CommandContext_$$_jvst9b7_2.java)
>         at 
> org.apache.isis.core.runtime.system.persistence.PersistenceSession.completeCommandFromInteractionAndClearDomainEvents(PersistenceSession.java:483)
>         at 
> org.apache.isis.core.runtime.system.persistence.PersistenceSession.close(PersistenceSession.java:414)
>         at 
> org.apache.isis.core.runtime.system.session.IsisSession.close(IsisSession.java:69)
>         at 
> org.apache.isis.core.runtime.system.session.IsisSessionFactory.closeSession(IsisSessionFactory.java:263)
>         at 
> org.apache.isis.core.runtime.system.session.IsisSessionFactory.doInSession(IsisSessionFactory.java:354)
>         at 
> org.apache.isis.core.runtime.system.session.IsisSessionFactory.doInSession(IsisSessionFactory.java:327)
>         at 
> org.apache.isis.viewer.wicket.viewer.integration.wicket.AuthenticatedWebSessionForIsis.getSessionLoggingService(AuthenticatedWebSessionForIsis.java:187)
>         at 
> org.apache.isis.viewer.wicket.viewer.integration.wicket.AuthenticatedWebSessionForIsis.log(AuthenticatedWebSessionForIsis.java:173)
>         at 
> org.apache.isis.viewer.wicket.viewer.integration.wicket.AuthenticatedWebSessionForIsis.onInvalidate(AuthenticatedWebSessionForIsis.java:120)
>         at 
> org.apache.wicket.session.HttpSessionStore$SessionBindingListener.valueUnbound(HttpSessionStore.java:471)
>         at 
> org.apache.catalina.session.StandardSession.removeAttributeInternal(StandardSession.java:1838)
>         at 
> org.apache.catalina.session.StandardSession.expire(StandardSession.java:891)
>         at 
> org.apache.catalina.session.StandardSession.isValid(StandardSession.java:694)
>         at 
> org.apache.catalina.session.ManagerBase.processExpires(ManagerBase.java:666)
>         at 
> org.apache.catalina.session.ManagerBase.backgroundProcess(ManagerBase.java:651)
>         at 
> org.apache.catalina.core.StandardContext.backgroundProcess(StandardContext.java:5625)
>         at 
> org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1377)
>         at 
> org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1381)
>         at 
> org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1381)
>         at 
> org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.run(ContainerBase.java:1349)
>         at java.lang.Thread.run(Thread.java:745)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to