Ok, thanks. I'll experiment with that last suggestion. Cheers, Dan On 28 Oct 2016 10:02, "Martin Grigorov" <[email protected]> wrote:
> On Fri, Oct 28, 2016 at 9:49 AM, Dan Haywood <[email protected] > > > wrote: > > > Thanks for that. > > > > We do use wicket-stuff, namely the notorious select2 component that we > have > > issues with. > > > > Right !! > > > > > > Talking of which, when I asked before if there were any alternative > widgets > > to select2, I think you said there weren't any really. Looking in your > > wicket-bootstrap stuff, though, I noticed that there is also > > bootstrap-select [1] with demo [2] and also typeahead [3] (which doesn't > > seem to have a demo). Do either of these miss some features that we > would > > require, do you think? > > > > I believe any of them will behave as Select2 as described at > https://issues.apache.org/jira/browse/ISIS-1224?focusedCommentId=15063757&; > page=com.atlassian.jira.plugin.system.issuetabpanels: > comment-tabpanel#comment-15063757 > I.e.: > 0) the user will leave the input field. This will lead to Ajax request > 1) the user will open the drop-down > 2) the Ajax response for 0) will replace the select widget, thus closing > the drop-down > 3) the user will need to re-open the drop-down again > > With the old code (still in use in Isis) the whole ReferencePanel is > repainted and this leads to the CSS issue with Select2. > With the suggested change only the Select2 component is repainted and the > CSS issue is no more there > > It is not perfect (the user has to open it twice) but this is how Isis > works - blur event for the text input fires an Ajax call that re-paints the > other form components in the dialog. > A possible improvement could be to repaint only the items in the drop-down, > instead of the whole Select2 component. Or maybe don't repaint Select2 at > all ?! It will make its own Ajax call to get the options anyway > > > > Thx > > Dan > > > > > > > > [1] > > https://github.com/l0rdn1kk0n/wicket-bootstrap/tree/wicket- > > 7.x/bootstrap-extensions/src/main/java/de/agilecoders/ > > wicket/extensions/markup/html/bootstrap/form/select > > [2] http://wb-mgrigorov.rhcloud.com/select > > [3] > > https://github.com/l0rdn1kk0n/wicket-bootstrap/tree/wicket- > > 7.x/bootstrap-extensions/src/main/java/de/agilecoders/ > > wicket/extensions/markup/html/bootstrap/form/typeaheadV10 > > > > > > > > > > > > On 28 October 2016 at 09:41, Martin Grigorov <[email protected]> > wrote: > > > > > Hi Dan, > > > > > > I've changed the subject to not add noise to the vote thread. > > > > > > Thanks for merging the wicket-7.x branch! > > > > > > Wicket 7.5.0 has been just announced. I guess you've noticed already. > > > It has the fix for the AuthenticatedWebSession#signedIn concurrency > > issue > > > reported by you. > > > > > > Wicket-Bootstrap 0.10.11 is recommended for 7.5.0. It depends on 7.4.0 > in > > > its pom.xml so you'll need to add exclusions to be able to build Isis. > > > > > > I'm currently releasing WicketStuff 7.5.0, but I think Isis doesn't use > > any > > > of the WS projects. > > > > > > Please let me know if you face any issues! > > > > > > > > > Martin Grigorov > > > Wicket Training and Consulting > > > https://twitter.com/mtgrigorov > > > > > > ---------- Forwarded message ---------- > > > From: Dan Haywood <[email protected]> > > > Date: Fri, Oct 28, 2016 at 9:21 AM > > > Subject: Re: [VOTE] Apache Isis Core release 1.13.1 RC1 > > > To: dev <[email protected]> > > > > > > > > > Thanks Martin. > > > > > > My +1 also. > > > > > > PS: I finally merged your branch for Wicket 7 into master, for a future > > > 1.14.0 release... thanks again for that. Some quick testing didn't > show > > up > > > any issues; will test more thoroughly with the kitchensinkapp. > > > > > > On 28 Oct 2016 09:05, "Martin Grigorov" <[email protected]> wrote: > > > > > > > +1 to release ! > > > > > > > > Martin Grigorov > > > > Wicket Training and Consulting > > > > https://twitter.com/mtgrigorov > > > > > > > > On Thu, Oct 27, 2016 at 1:31 AM, Dan Haywood < > > > [email protected] > > > > > > > > > wrote: > > > > > > > > > I've cut a release for Apache Isis Core and the simpleapp > archetype: > > > > > > > > > > * Core 1.13.1 > > > > > * SimpleApp Archetype 1.13.1 > > > > > > > > > > The source code artifacts have been uploaded to staging > repositories > > on > > > > > repository.apache.org: > > > > > > > > > > * > > > > > http://repository.apache.org/content/repositories/ > > > > > orgapacheisis-1051/org/apache/isis/core/isis/1.13.1/isis-1. > > > > > 13.1-source-release.zip > > > > > * > > > > > http://repository.apache.org/content/repositories/ > > > > > orgapacheisis-1051/org/apache/isis/archetype/simpleapp- > > > > > archetype/1.13.1/simpleapp-archetype-1.13.1-source-release.zip > > > > > > > > > > For each zip there is a corresponding signature file (append .asc > to > > > the > > > > > zip's url). > > > > > > > > > > In the source code repo the code has been tagged as isis-1.13.1-RC1 > > and > > > > > simpleapp-archetype-1.13.1-RC1; see > > > > > https://git-wip-us.apache.org/repos/asf?p=isis.git > > > > > > > > > > For instructions on how to verify the release (build from binaries > > > and/or > > > > > use in Maven directly), see > > > > > http://isis.apache.org/guides/cgcom.html#_cgcom_verifying-releases > > > > > > > > > > Please verify the release and cast your vote. The vote will be > open > > > for > > > > a > > > > > minimum of 72 hours. > > > > > > > > > > [ ] +1 > > > > > [ ] 0 > > > > > [ ] -1 > > > > > > > > > > > > > > >
