[ 
https://issues.apache.org/jira/browse/ISIS-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106552#comment-16106552
 ] 

Dan Haywood commented on ISIS-1670:
-----------------------------------

created a branch for this.  However, not enough to naively just change the 
callback hook... as the commit says on the branch:

ISIS-1670: changes ScalarPanelAbstract2 to use onInitialize to onBefore

NB: work-in-progress, this doesn't correctly work because doesn't install all 
the callbacks as required.  For example, in kitchensink, if bring up a 
ReferenceObject, and change "Some Other Object Optional With Choices" (as an 
editable property), first time works, but second time the callback to bring up 
the prompt is not installed.


> ScalarPanelAbstract2 in edit mode (or with INLINE_AS_IF_EDIT action) does not 
> dynamically update enablement/disability based on other state.
> --------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-1670
>                 URL: https://issues.apache.org/jira/browse/ISIS-1670
>             Project: Isis
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.14.0
>            Reporter: Dan Haywood
>            Priority: Minor
>             Fix For: 2.1.0
>
>
> ... because the gui is built during onInitialize callback, and this is called 
> when re-rendered
> Funnily enough, ScalarPanelAbstract (which ScalarPanelAbstract2 replaces) 
> uses onBeforeRender.
> Am guessing there was probably a reason to move the gui building to 
> onInitialize...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to