[ 
https://issues.apache.org/jira/browse/ISIS-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221307#comment-16221307
 ] 

Dan Haywood commented on ISIS-1756:
-----------------------------------

Hi [~hobrom], quick request: could you format commit messages as:

ISIS-nnnn: active sentence which describes the change

for example:

ISIS-1756: adds destroy() method to IsisContext, and deprecates testReset()

Also (very minor point), when I deprecate I use both the javadoc @deprecated 
and also the @Deprecated annotation.  

thx
Dan

> JEE Support - IsisContext requires proper lifecycling.
> ------------------------------------------------------
>
>                 Key: ISIS-1756
>                 URL: https://issues.apache.org/jira/browse/ISIS-1756
>             Project: Isis
>          Issue Type: Improvement
>    Affects Versions: 1.15.1
>            Reporter: Dan Haywood
>            Assignee: Andi Huber
>             Fix For: 2.0.0
>
>
> as per 
> https://lists.apache.org/thread.html/a815c6d3e50c02111d0cd3df93b70b529c18193f321e613b116119b4@%3Cdev.isis.apache.org%3E
> The isis-context needs a proper lifecycling, meaning a  deploy/undeploy cycle 
> should properly invalidate any state. (e.g meta model validation is currently 
> not cleared after an undeploy, in my case after calling 
> IsisContext.testReset())



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to