Hi folks, We have +2 on this, however there are a number of small issues@ - Kevin found an issue with the release instructions which should be tidied up - I learnt from Andi that it would be good to get ISIS-1852 (InheritableThreadLocal) as part of the release - there's also an improvement that could be made to ISIS-1585 (checkboxes on parented collections).
So, I'm gonna cancel this RC1, fix those issues, and go round the loop again for an RC2. Thx Dan On Thu, 15 Feb 2018 at 19:27 Kevin Meyer <ke...@kmz.co.za> wrote: > Ok, I'll +1 but with reservations > > Comments: > - I could only compile and install the core components by commenting out > the "git-commit-id-plugin" sections in the root pom.xml > - The instructions in the committers guide do not work: > * mvn dependency:go-offline fails > * All the offline "-o" instructions fail (there are always dependencies > that need to be downloaded, and they *only* download successfully with an > online compilation) > > Is it just me? > Can someone else flush their repository: > $ rm -rf ~/.m2/repostitory/[a-z] > and check the first instructions: > $ unzip isis-1.16.1-source-release.zip > $ cd isis-1.16.1 > $ mvn dependency:go-offline > > Cheers, > Kevin > > On Thu, February 15, 2018 19:46, Kevin Meyer wrote: > > I get a build failure: > > > > > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] BUILD FAILURE > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] Total time: 13.391 s > > [INFO] Finished at: 2018-02-15T19:44:04+01:00 > > [INFO] Final Memory: 33M/385M > > [INFO] > > ------------------------------------------------------------------------ > > [ERROR] Failed to execute goal > > pl.project13.maven:git-commit-id-plugin:2.2.3:revision > (get-the-git-infos) > > on project isis-core-schema: .git directory is not found! Please specify > > a valid [dotGitDirectory] in your pom.xml -> [Help 1] [ERROR] > > [ERROR] To see the full stack trace of the errors, re-run Maven with the > > -e switch. > > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > > [ERROR] > > [ERROR] For more information about the errors and possible solutions, > > please read the following articles: [ERROR] [Help 1] > > http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException > > [ERROR] > > [ERROR] After correcting the problems, you can resume the build with the > > command [ERROR] mvn <goals> -rf :isis-core-schema > > > > > > Any advice? > > > > > > Cheers, > > Kevin > > > > > > > > On Wed, February 14, 2018 11:10, Dan Haywood wrote: > > > >> I've cut a release for Apache Isis Core and the two archetypes: > >> > >> > >> > >> * Core 1.16.1 > >> * HelloWorld Archetype 1.16.1 > >> * SimpleApp Archetype 1.16.1 > >> > >> > >> > >> The source code artifacts have been uploaded to staging repositories on > >> repository.apache.org: > >> > >> > >> > >> * > >> > http://repository.apache.org/content/repositories/orgapacheisis-1064/org > >> /a > >> pache/isis/core/isis/1.16.1/isis-1.16.1-source-release.zip * > >> http://repository.apache.org/content/repositories/orgapacheisis-1065/or > >> g/a > >> pache/isis/archetype/helloworld-archetype/1.16.1/helloworld-archetype-1 > >> .1 > >> 6.1-source-release.zip > >> * > >> > http://repository.apache.org/content/repositories/orgapacheisis-1065/org > >> /a > >> pache/isis/archetype/simpleapp-archetype/1.16.1/simpleapp-archetype-1.16 > >> . > >> 1-source-release.zip > >> > >> > >> > >> For each zip there is a corresponding signature file (append .asc to > >> the zip's url). > >> > >> In the source code repo the code has been tagged as isis-1.16.1-RC1, > >> helloworld-archetype-1.16.1-RC1 and simpleapp-archetype-1.16.1-RC1; see > >> https://github.com/apache/isis/tags > >> > >> > >> > >> For instructions on how to verify the release (build from binaries > >> and/or use in Maven directly), see > >> https://isis.apache.org/guides/cgcom/cgcom.html#_cgcom_verifying-releas > >> es > >> > >> > >> Please verify the release and cast your vote. The vote will be open > >> for a minimum of 72 hours. > >> > >> [ ] +1 > >> [ ] 0 > >> [ ] -1 > >> > >> > >> > > > > > > > -- > Kevin Meyer > Ljubljana, Slovenia > > >
