[
https://issues.apache.org/jira/browse/ISIS-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384600#comment-16384600
]
Andi Huber edited comment on ISIS-1172 at 3/3/18 10:27 AM:
-----------------------------------------------------------
logo resolution is now context-path sensitive:
resolved for both ...
{code:java}
bind(String.class).annotatedWith(Names.named("brandLogoHeader")).toInstance("/images/raven.png");
bind(String.class).annotatedWith(Names.named("brandLogoSignin")).toInstance("/images/raven.png");
{code}
was (Author: hobrom):
logo resolution is now context-path sensitive:
resolved for both ...
{code:java}
bind(String.class).annotatedWith(Names.named("brandLogoHeader")).toInstance("/images/raven.png");
bind(String.class).annotatedWith(Names.named("brandLogoSignin")).toInstance("/images/raven.png");
{code}
> Logo in wicket viewer should be calculated relative to context root
> -------------------------------------------------------------------
>
> Key: ISIS-1172
> URL: https://issues.apache.org/jira/browse/ISIS-1172
> Project: Isis
> Issue Type: Bug
> Components: Core: Viewer: Wicket
> Affects Versions: 1.9.0
> Reporter: Jörg Rade
> Assignee: Andi Huber
> Priority: Minor
> Fix For: 2.0.0-M1
>
>
> {code}
> bind(String.class).annotatedWith(Names.named("brandLogoHeader"))
> .toInstance("/images/knife-logo-header.png");
> {code}
> doesn't work for me. I had to specify
> "/sdm-webapp/images/knife-logo-header.png".
> Tried. using "images/knife-logo-header.png" (-)
> Compared generated the simple app from the maven archetype and diffed my
> web.xml against the generated and adopted my web.xml to match my
> SimpleApplication package name. (-)
> Analysis by Martin:
> Wicket automatically calculates the context relative path for plain HTML
> <img> elements in your markup.
> In the current case the <img> element is connected to a Java component, i.e.
> it has wicket:id attribute, and that's why Wicket doesn't apply any special
> logic on it.
> IMO we should improve Isis to always calculate context relative path for the
> logo url.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
