[ 
https://issues.apache.org/jira/browse/ISIS-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1914:
------------------------------
    Description: 
Instead, should work only at the Module level.

~~~

this is prompted by Andi's original reason for raising this ticket, where he 
noted:

 

Adding a Service outside of the scope of configured modules fails with
{noformat}
java.lang.AssertionError: Metamodel is invalid: 
Domain objects discovered in package 'x.x.x' are not in the set of modules 
obtained from the AppManifest's top-level module 'y.y.y.MyModule'.  Classes 
are: x.x.x.MyService
{noformat}
+Source:+
{code:java}
public abstract class DomainAppIntegTestAbstract extends 
IntegrationTestAbstract3 {

    public DomainAppIntegTestAbstract() {
        super(new MyModule()
                .withAdditionalServices(MyService.class)
                                
                ...
                                
                ;
    }

}
{code}
If this behavior is intended, than what is the point of adding additional 
services?

 

~~~

^^^ which is a fair point.  So, we ought to just get rid of that capability to 
add adhoc services, and instead require only that the user specifies additional 
modules (which they already can do) and pick up any services within those 
modules.

 

  was:
Adding a Service outside of the scope of configured modules fails with
{noformat}
java.lang.AssertionError: Metamodel is invalid: 
Domain objects discovered in package 'x.x.x' are not in the set of modules 
obtained from the AppManifest's top-level module 'y.y.y.MyModule'.  Classes 
are: x.x.x.MyService
{noformat}
+Source:+
{code:java}
public abstract class DomainAppIntegTestAbstract extends 
IntegrationTestAbstract3 {

    public DomainAppIntegTestAbstract() {
        super(new MyModule()
                .withAdditionalServices(MyService.class)
                                
                ...
                                
                ;
    }

}
{code}
If this behavior is intended, than what is the point of adding additional 
services?


> Remove the ability to add additional services to an AppManifest or Module
> -------------------------------------------------------------------------
>
>                 Key: ISIS-1914
>                 URL: https://issues.apache.org/jira/browse/ISIS-1914
>             Project: Isis
>          Issue Type: Question
>            Reporter: Andi Huber
>            Priority: Major
>             Fix For: 2.0.0-M2
>
>
> Instead, should work only at the Module level.
> ~~~
> this is prompted by Andi's original reason for raising this ticket, where he 
> noted:
>  
> Adding a Service outside of the scope of configured modules fails with
> {noformat}
> java.lang.AssertionError: Metamodel is invalid: 
> Domain objects discovered in package 'x.x.x' are not in the set of modules 
> obtained from the AppManifest's top-level module 'y.y.y.MyModule'.  Classes 
> are: x.x.x.MyService
> {noformat}
> +Source:+
> {code:java}
> public abstract class DomainAppIntegTestAbstract extends 
> IntegrationTestAbstract3 {
>     public DomainAppIntegTestAbstract() {
>         super(new MyModule()
>               .withAdditionalServices(MyService.class)
>                               
>               ...
>                               
>               ;
>     }
> }
> {code}
> If this behavior is intended, than what is the point of adding additional 
> services?
>  
> ~~~
> ^^^ which is a fair point.  So, we ought to just get rid of that capability 
> to add adhoc services, and instead require only that the user specifies 
> additional modules (which they already can do) and pick up any services 
> within those modules.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to