[
https://issues.apache.org/jira/browse/ISIS-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839472#comment-16839472
]
ASF subversion and git services commented on ISIS-2118:
-------------------------------------------------------
Commit 75db8ce9dc24c6cabce00a901cc35f9300085478 in isis's branch
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=75db8ce ]
ISIS-2118: removes dead code that is no longer called
> Don't redundantly add additional DisabledFacet when disabled at class-level.
> ----------------------------------------------------------------------------
>
> Key: ISIS-2118
> URL: https://issues.apache.org/jira/browse/ISIS-2118
> Project: Isis
> Issue Type: Bug
> Affects Versions: 1.17.0
> Reporter: Dan Haywood
> Assignee: Dan Haywood
> Priority: Minor
> Fix For: 1.18.0
>
>
> using the ISIS-2015 mixin, I see the following for kitchensink's
> ReferenceObject when annotated as @DomainObject(editing=DISABLED)
> {code}
> <mml:prop id="otherName">
> <mml:facets>
> ...
> <mml:facet
> id="org.apache.isis.core.metamodel.facets.members.disabled.DisabledFacet"
> fqcn="org.apache.isis.core.metamodel.facets.properties.disabled.fromimmutable.DisabledFacetOnPropertyDerivedFromImmutable">
> <mml:attr name="disabling">true</mml:attr>
> <mml:attr name="inverted">false</mml:attr>
> <mml:attr name="semantics">DISABLED</mml:attr>
> <mml:attr name="when">ALWAYS</mml:attr>
> <mml:attr name="where">ANYWHERE</mml:attr>
> </mml:facet>
> ...
> <mml:facet
> id="org.apache.isis.core.metamodel.facets.object.immutable.ImmutableFacet"
> fqcn="org.apache.isis.core.metamodel.facets.object.domainobject.editing.ImmutableFacetForDomainObjectAnnotation">
> <mml:attr name="disabling">true</mml:attr>
> <mml:attr name="reason">Disabled</mml:attr>
> <mml:attr name="when">ALWAYS</mml:attr>
> </mml:facet>
> {code}
> The ImmutableFacet isn't required, because the
> DisabledFacetOnPropertyDerivedFromImmutable should suffice.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
