[
https://issues.apache.org/jira/browse/ISIS-2476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17257789#comment-17257789
]
ASF subversion and git services commented on ISIS-2476:
-------------------------------------------------------
Commit cd5b3fe9e9b2a4c95cc4d01978e7330b35d9f3e1 in isis's branch
refs/heads/ISIS-2476 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=cd5b3fe ]
ISIS-2476: improves the custom ui example a little
> Remove EntityLinksSelectorPanel, as is dead code, and allow other
> implementations of ComponentType.ENTITY to be picked up.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: ISIS-2476
> URL: https://issues.apache.org/jira/browse/ISIS-2476
> Project: Isis
> Issue Type: Improvement
> Components: Isis Viewer Wicket
> Affects Versions: 2.0.0-M4
> Reporter: Daniel Keir Haywood
> Assignee: Daniel Keir Haywood
> Priority: Minor
> Fix For: 2.0.0-M5
>
>
> EntityLinksSelectorPanelFactory can actually return either a Bs3GridPanel, or
> an EntityLinksSelectorPanel. Except it always does the former, and the
> latter is dead code.
> That means in turn that EntityLinksSelectorPanelFactory is (a) misnamed and
> (b) should not be given special priority in ComponentFactoryRegisterDefault
> as a selector ... it should be just another built-in.
> That would then allow other implementations of the ComponentType.ENTITY to be
> picked up.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
