[
https://issues.apache.org/jira/browse/ISIS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Keir Haywood updated ISIS-2555:
--------------------------------------
Description:
The docs say that EntityChanges releates to a transaction, but it only has a
uniqueId which identifies the parent interaction (there can be many
transactions per interaction). So, we're missing a sequence.
EntityChanges also has a reference to ChangesDto, which contains a sequence, so
I think the information is there.
There is also a TransactionId which is the tuple of uniqueId (for interaction)
and sequence, so in fact EntityChanges should probably have a field of type
TranscationId rather than UUID uniqueId.
~~~
Similarly, EntityPropertyChange has both a uniqueId and a sequence, so they
should be replaced by a field of type TransactionId instead.
was:The docs say that EntityChanges has a uniqueId relating to a transaction,
but I suspect it relates to the Interaction. We do have a TransactionId that
adds in a sequence (multiple transactions per interaction), so I think that
EntityChanges should probably reference that.
> EntityChanges (as consumed by EntityChangesSubscriber) should associate with
> transaction, not interaction?
> ----------------------------------------------------------------------------------------------------------
>
> Key: ISIS-2555
> URL: https://issues.apache.org/jira/browse/ISIS-2555
> Project: Isis
> Issue Type: Improvement
> Components: Isis Core
> Reporter: Daniel Keir Haywood
> Priority: Minor
> Fix For: 2.0.0-M6
>
>
> The docs say that EntityChanges releates to a transaction, but it only has a
> uniqueId which identifies the parent interaction (there can be many
> transactions per interaction). So, we're missing a sequence.
> EntityChanges also has a reference to ChangesDto, which contains a sequence,
> so I think the information is there.
> There is also a TransactionId which is the tuple of uniqueId (for
> interaction) and sequence, so in fact EntityChanges should probably have a
> field of type TranscationId rather than UUID uniqueId.
>
> ~~~
> Similarly, EntityPropertyChange has both a uniqueId and a sequence, so they
> should be replaced by a field of type TransactionId instead.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
