mwhesse commented on a change in pull request #513:
URL: https://github.com/apache/isis/pull/513#discussion_r619576045
##########
File path:
viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/bookmarkedpages/BookmarkedPagesPanel.html
##########
@@ -25,7 +25,7 @@
<body>
<wicket:panel>
<div class="bookmarkedPagesPanel">
- <div class="showPanelTab bookmarkRibbon bg-light ml-0"></div>
+ <div class="showPanelTab bookmarkRibbon bg-secondary
ml-0"></div>
Review comment:
in BS3 there was a class called navbar-inverted, but that has been
removed
##########
File path:
viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/bookmarkedpages/BookmarkedPagesPanel.html
##########
@@ -25,7 +25,7 @@
<body>
<wicket:panel>
<div class="bookmarkedPagesPanel">
- <div class="showPanelTab bookmarkRibbon bg-light ml-0"></div>
+ <div class="showPanelTab bookmarkRibbon bg-secondary
ml-0"></div>
Review comment:
in BS3 there was a class called navbar-inverted, but that has been
removed in BS4
##########
File path:
viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/jquery.isis.wicket.viewer.js
##########
@@ -195,6 +195,37 @@ $(function() {
});
*/
+ /*
+ * Adapted from https://bootstrap-menu.com/detail-basic-hover.html
+ * Changes:
+ * - ignoring mouseleave events if hovering over a popover
+ */
+ if (window.innerWidth > 992) {
Review comment:
This probably needs some more scrutiny, the event listeners should
always be registered, but only react on the right screen size
##########
File path:
viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/bookmarkedpages/BookmarkedPagesPanel.html
##########
@@ -25,7 +25,7 @@
<body>
<wicket:panel>
<div class="bookmarkedPagesPanel">
- <div class="showPanelTab bookmarkRibbon bg-light ml-0"></div>
+ <div class="showPanelTab bookmarkRibbon bg-secondary
ml-0"></div>
Review comment:
We could invent our own "inverted" background colors, "bg-inverted", but
we would have to do so for all themes we are supporting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
