mwhesse commented on a change in pull request #505:
URL: https://github.com/apache/isis/pull/505#discussion_r619650965
##########
File path:
viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actionmenu/serviceactions/ServiceActionsPanel.java
##########
@@ -38,7 +38,7 @@
import lombok.val;
-import
de.agilecoders.wicket.extensions.markup.html.bootstrap.button.DropdownAutoOpenJavaScriptReference;
+// import
de.agilecoders.wicket.extensions.markup.html.bootstrap.button.DropdownAutoOpenJavaScriptReference;
Review comment:
New behavior is now contributed here:
https://github.com/apache/isis/commit/f614ca4b9630ae08c898af09bb0be1d0326b3f29#diff-6f57cd3d3471edc5af13ddad17e104d475605809bc48e744135d85f157605c46
##########
File path:
viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actionmenu/serviceactions/ServiceActionsPanel.java
##########
@@ -83,8 +83,8 @@ public void renderHead(IHeaderResponse response) {
response.render(CssHeaderItem.forReference(new
CssResourceReference(ServiceActionsPanel.class, "ServiceActionsPanel.css")));
Tooltips.renderHead(response);
-
response.render(JavaScriptHeaderItem.forReference(DropdownAutoOpenJavaScriptReference.instance()));
-
response.render(OnDomReadyHeaderItem.forScript("$('.dropdown-toggle').dropdownHover();"));
+ //
response.render(JavaScriptHeaderItem.forReference(DropdownAutoOpenJavaScriptReference.instance()));
Review comment:
Can be removed
##########
File path:
viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/datepicker/TextFieldWithDateTimePicker.java
##########
@@ -91,7 +91,12 @@ public TextFieldWithDateTimePicker(
config.minDate(datePickerMinDate);
config.maxDate(datePickerMaxDate);
-
+
+ boolean enabled = this.isEnabled();
+
+ // config.keepOpen(true);
Review comment:
remove this line
##########
File path:
viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/themepicker/ThemeChooser.java
##########
@@ -47,8 +47,8 @@
import de.agilecoders.wicket.themes.markup.html.bootstrap.BootstrapThemeTheme;
import de.agilecoders.wicket.themes.markup.html.bootswatch.BootswatchTheme;
import
de.agilecoders.wicket.themes.markup.html.bootswatch.BootswatchThemeProvider;
-import de.agilecoders.wicket.themes.markup.html.vegibit.VegibitTheme;
-import de.agilecoders.wicket.themes.markup.html.vegibit.VegibitThemeProvider;
+// import de.agilecoders.wicket.themes.markup.html.vegibit.VegibitTheme;
Review comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
