[
https://issues.apache.org/jira/browse/ISIS-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349323#comment-17349323
]
ASF subversion and git services commented on ISIS-2253:
-------------------------------------------------------
Commit 7e46a6201f55144aff5a17abb46a00bfe5ad8bb6 in isis's branch
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=7e46a62 ]
ISIS-2253: remove MM validation hotfix; provide regr. tests
> Derive ChoicesFacet from ChoicesFromFacet, remove special-case logic.
> ---------------------------------------------------------------------
>
> Key: ISIS-2253
> URL: https://issues.apache.org/jira/browse/ISIS-2253
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
> Reporter: Andi Huber
> Assignee: Andi Huber
> Priority: Minor
> Fix For: 2.0.0-M6
>
>
> In fact, this is a case of two wrongs not quite making a right. There's a
> nasty hack in that it is the Wicket viewer that knows how to populate the
> choices for the parameter, and it does this without looking for an
> autoComplete or choices facet ; it just picks up the checked items of the
> associated collection.
> The short term solution to fix DemoApp is just to update that metamodel
> validator to also take into account any AssociatedWithFacet.
> The long term "correct" solution is a new facet factory that will derive a
> ChoicesFacet from the AssociatedWithFacet, and then to remove the special
> case logic from the Wicket viewer.
> That would then make the validator correct as it is now written.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
