[ 
https://issues.apache.org/jira/browse/ISIS-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350847#comment-17350847
 ] 

Andi Huber edited comment on ISIS-2631 at 5/25/21, 3:13 PM:
------------------------------------------------------------

Also in ApplicationFeatureId for actions there are now 2 different member 
names, one including the param-list and one not including the param-list. 
Should find good terminology to distinguish these as well.

UPDATE:  it turned out we don't need to consider any param-list with 
ApplicationFeatureId: action overloading is not allowed/supported and for 
action/association name clashes we can live with the consequences of 
permissions automatically applying to both


was (Author: hobrom):
Also in ApplicationFeatureId for actions there are now 2 different member 
names, one including the param-list and one not including the param-list. 
Should find good terminology to distinguish these as well.

> Make terminology consistent in applib (@DomainObject(objectType=...), 
> TableColumnOrderService, ApplicationFeatureId, BookmarkService)
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-2631
>                 URL: https://issues.apache.org/jira/browse/ISIS-2631
>             Project: Isis
>          Issue Type: Improvement
>          Components: Isis Applib (programming model)
>    Affects Versions: 2.0.0-M5
>            Reporter: Daniel Keir Haywood
>            Assignee: Andi Huber
>            Priority: Minor
>             Fix For: 2.0.0-M6
>
>
> we have logicalTypeName and objectType, that are the same thing.  The latter 
> has been around longer so think we should use that
> in ApplicationFeatureId, we have memberName, but in TableColumnOrderService 
> we have propertyId.  "Id" is the correct nomenclature, a "name" is usually a 
> friendly name as appears in the UI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to