[ 
https://issues.apache.org/jira/browse/ISIS-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351257#comment-17351257
 ] 

ASF subversion and git services commented on ISIS-2694:
-------------------------------------------------------

Commit ce188b51830ba17848aaae5aaab3c6152fe382b8 in isis's branch 
refs/heads/ISIS-2697 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ce188b5 ]

ISIS-2694: removes guard to hide newDelegateUser

so, even if the realm (eg shiro) isn't configured for delegates, we don't care 
anymore.

This will allow us to delete a bunch of code


> Can we simplify secman and get rid of SecurityRealm / 
> SecurityRealmCharacteristics ?
> ------------------------------------------------------------------------------------
>
>                 Key: ISIS-2694
>                 URL: https://issues.apache.org/jira/browse/ISIS-2694
>             Project: Isis
>          Issue Type: Improvement
>          Components: Isis Extensions SecMan
>    Affects Versions: 2.0.0-M5
>            Reporter: Daniel Keir Haywood
>            Assignee: Daniel Keir Haywood
>            Priority: Minor
>             Fix For: 2.0.0-M6
>
>         Attachments: image-2021-05-24-22-41-32-839.png
>
>
> There's quite a few types here (SecurityRealmService, SecurityRealm, 
> SecurityRealmCharacteristics) along with a requirement for the end-developer 
> to instantiate a SecurityRealmService bean... but all we do is use the value 
> to hide/not hide an action.   
>  
> !image-2021-05-24-22-41-32-839.png|width=526,height=135!
> Seems to be over-engineered?  Can this be simplified, or perhaps even just 
> removed?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to