danhaywood commented on a change in pull request #587:
URL: https://github.com/apache/isis/pull/587#discussion_r647528049
##########
File path:
core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/hidden/HiddenTypeFacetDerivedFromAuthorization.java
##########
@@ -29,14 +29,16 @@
import lombok.val;
-public class HiddenTypeFacetDerivedFromAuthorization extends FacetAbstract
implements HiddenTypeFacet {
+public class HiddenTypeFacetDerivedFromAuthorization
+extends FacetAbstract
+implements HiddenTypeFacet {
public static Class<? extends Facet> type() {
return HiddenTypeFacet.class;
}
public HiddenTypeFacetDerivedFromAuthorization(final FacetHolder holder) {
- super(type(), holder);
+ super(type(), holder, Precedence.DERIVED);
Review comment:
Although this facet's class name has the word "derived" in it, I'm not
sure it automatically means that it's precedence is DERIVED.
The semantics of DERIVED (nb: this is not documented anywhere) is for a
facet that is inferred from other facets, but which could be overridden by
something that is more specific.
That isn't the case here: the type should always be hidden if all of the
members are.
It should probably be named
"HiddenTypeFacetInferredFromNoAuthorisationToAnyMember" or something similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
