danhaywood commented on a change in pull request #590:
URL: https://github.com/apache/isis/pull/590#discussion_r648483475
##########
File path:
api/applib/src/main/java/org/apache/isis/applib/services/iactnlayer/InteractionContext.java
##########
@@ -69,15 +75,53 @@
@With @Getter @Builder.Default
@NonNull TimeZone timeZone = TimeZone.getDefault();
+ Map<String, Serializable> attributes = new HashMap<>();
Review comment:
Hmm, ok. What I was aiming to do, as I hope is clear, is have the new
InteractionService only know about InteractionContext, not about the fact that
usually an InteractionContext comes from an Authentication. So this was a way
to invert the dependency (or make it bidirectional, in fact).
Where we are now is that InteractionLayer binds together (Isis)Interation =
"what" is being executed + InteractionContext (= "who", "when" and "where"
being executed). Authentication is just a thin wrapper around
InteractionContext, which holds the "who". Using (Isis)Interaction to hold
onto these "who" attributes seems a bit wierd.
I'm just wondering - perhaps InteractionLayer might be a better place for
these attributes than either (Isis)Interaction or InteractionContext. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
