[ 
https://issues.apache.org/jira/browse/ISIS-2776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374392#comment-17374392
 ] 

ASF subversion and git services commented on ISIS-2776:
-------------------------------------------------------

Commit 0b4e9c158522bd10f0826243b080854d73083a57 in isis's branch 
refs/heads/master from Daniel Keir Haywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=0b4e9c1 ]

Merge pull request #650 from apache/ISIS-2776

ISIS-2776: adds guard for null string in regex facet

> @Parameter(regex=...) does not allow for parameter to also be optional.
> -----------------------------------------------------------------------
>
>                 Key: ISIS-2776
>                 URL: https://issues.apache.org/jira/browse/ISIS-2776
>             Project: Isis
>          Issue Type: Bug
>          Components: Isis Core
>    Affects Versions: 2.0.0-M5
>            Reporter: Daniel Keir Haywood
>            Assignee: Daniel Keir Haywood
>            Priority: Minor
>             Fix For: 2.0.0-M6
>
>
> In other words, if null is provided then the regex fails.  It should just 
> ignore.
> This shows up as a problem for the simple case, eg:
> `@Parameter(regex=..., optionality=OPTIONAL)`
> it also shows up in the case of a chained meta-annotation:
> {code:java}
> @Parameter(regex=..., optionality=MANDATORY)
> public @interface Reference {}{code}
> and
> {code:java}
> @Parameter(optionality=OPTIONAL)
> @Reference
> public @interface VatCode {} {code}
> where we want parameters annotated with `@VatCode` to be optional, overriding 
> the inherited mandatory from `@Reference`.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to