andi-huber commented on a change in pull request #817:
URL: https://github.com/apache/isis/pull/817#discussion_r777323611
##########
File path: examples/demo/pom.xml
##########
@@ -238,12 +243,12 @@
</activation>
<modules>
<module>domain</module>
- <module>javafx</module>
+ <!--module>javafx</module-->
<module>web</module>
<module>wicket/common</module>
<module>wicket/jdo</module>
<module>wicket/jpa</module>
- <module>vaadin</module>
+ <!--module>vaadin</module-->
Review comment:
any reason why this was removed?
##########
File path: examples/demo/pom.xml
##########
@@ -238,12 +243,12 @@
</activation>
<modules>
<module>domain</module>
- <module>javafx</module>
+ <!--module>javafx</module-->
Review comment:
any reason why this was removed?
##########
File path: examples/demo/domain/pom.xml
##########
@@ -27,29 +27,63 @@
<properties>
</properties>
- <build>
- <resources>
- <resource>
- <filtering>true</filtering>
- <directory>src/main/resources</directory>
- <includes>
- <include>application.yml</include>
- </includes>
- </resource>
- <resource>
- <filtering>false</filtering>
- <directory>src/main/resources</directory>
- </resource>
- <resource>
- <filtering>false</filtering>
- <directory>src/main/java</directory>
- <includes>
- <!-- we include all .java too, so that
we can reference it from the descriptions -->
- <include>**</include>
- </includes>
- </resource>
- </resources>
- </build>
+ <build>
+ <plugins>
+ <plugin>
Review comment:
Maybe add a short explanatory comment, for the motivation of adding this
plugin. (I guess some copy&past from this PR's description should suffice)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
