[ 
https://issues.apache.org/jira/browse/ISIS-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17483349#comment-17483349
 ] 

Andi Huber commented on ISIS-2948:
----------------------------------

Taking a look at

{code:java}
class JavaLangStrings  {

    @Collection
    public List<? extends JavaLangStringEntity> getEntities() {
        return entities.all();
    }
}
{code}

It seems the RO-Viewer, does produce a false response with 
urn:org.restfulobjects:rels/element-type ...

{code:java}
 {
    "rel" : "urn:org.restfulobjects:rels/element-type",
    "href" : 
"http://localhost:8080/restful/domain-types/demo.JavaLangStringHolder";,
    "method" : "GET",
    "type" : 
"application/json;profile=\"urn:org.restfulobjects:repr-types/domain-type\""
  }
{code}

I believe the element-type should rather be JavaLangStringEntity than 
JavaLangStringHolder.

> [RO Viewer] Element-type not correctly represented for Collections.
> -------------------------------------------------------------------
>
>                 Key: ISIS-2948
>                 URL: https://issues.apache.org/jira/browse/ISIS-2948
>             Project: Isis
>          Issue Type: New Feature
>          Components: Isis Viewer RO
>    Affects Versions: 2.0.0-M6
>            Reporter: Jörg Rade
>            Assignee: Andi Huber
>            Priority: Major
>             Fix For: 2.0.0-M7
>
>
> I'm on master and get a.m. message for 
> http://localhost:8080/restful/domain-types/demo.JavaLangStringHolder
> {code:java}
> org.apache.isis.viewer.restfulobjects.rendering.domaintypes.DomainTypeReprRenderer.render(DomainTypeReprRenderer.java:70)
> org.apache.isis.viewer.restfulobjects.rendering.Responses.ofOk(Responses.java:67)
> org.apache.isis.viewer.restfulobjects.rendering.Responses.ofOk(Responses.java:56)
> org.apache.isis.viewer.restfulobjects.viewer.resources.DomainTypeResourceServerside.domainType(DomainTypeResourceServerside.java:134)
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> java.base/java.lang.reflect.Method.invoke(Method.java:566)
> org.jboss.resteasy.core.MethodInjectorImpl.invoke(MethodInjectorImpl.java:170)
> org.jboss.resteasy.core.MethodInjectorImpl.invoke(MethodInjectorImpl.java:130)
> org.jboss.resteasy.core.ResourceMethodInvoker.internalInvokeOnTarget(ResourceMethodInvoker.java:660)
> org.jboss.resteasy.core.ResourceMethodInvoker.invokeOnTargetAfterFilter(ResourceMethodInvoker.java:524)
> org.jboss.resteasy.core.ResourceMethodInvoker.lambda$invokeOnTarget$2(ResourceMethodInvoker.java:474)
> org.jboss.resteasy.core.interception.jaxrs.PreMatchContainerRequestContext.filter(PreMatchContainerRequestContext.java:364)
> org.jboss.resteasy.core.ResourceMethodInvoker.invokeOnTarget(ResourceMethodInvoker.java:476)
> org.jboss.resteasy.core.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:434)
> org.jboss.resteasy.core.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:408)
> org.jboss.resteasy.core.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:69)
> org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:492)
> org.jboss.resteasy.core.SynchronousDispatcher.lambda$invoke$4(SynchronousDispatcher.java:261)
> org.jboss.resteasy.core.SynchronousDispatcher.lambda$preprocess$0(SynchronousDispatcher.java:161)
> org.jboss.resteasy.core.interception.jaxrs.PreMatchContainerRequestContext.filter(PreMatchContainerRequestContext.java:364)
> org.jboss.resteasy.core.SynchronousDispatcher.preprocess(SynchronousDispatcher.java:164)
> org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:247)
> org.jboss.resteasy.plugins.server.servlet.ServletContainerDispatcher.service(ServletContainerDispatcher.java:249)
> org.jboss.resteasy.plugins.server.servlet.HttpServletDispatcher.service(HttpServletDispatcher.java:60)
> org.jboss.resteasy.plugins.server.servlet.HttpServletDispatcher.service(HttpServletDispatcher.java:55)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:764)
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
> org.apache.isis.viewer.restfulobjects.viewer.webmodule.IsisRestfulObjectsInteractionFilter.lambda$doFilter$1(IsisRestfulObjectsInteractionFilter.java:387)
> org.apache.isis.commons.functional.ThrowingRunnable.lambda$toCallable$0(ThrowingRunnable.java:42)
> org.apache.isis.commons.functional.Result.of(Result.java:58)
> org.apache.isis.core.runtimeservices.transaction.TransactionServiceSpring.callTransactional(TransactionServiceSpring.java:108)
> org.apache.isis.applib.services.xactn.TransactionalProcessor.callWithinCurrentTransactionElseCreateNew(TransactionalProcessor.java:100)
> org.apache.isis.applib.services.xactn.TransactionalProcessor.runWithinCurrentTransactionElseCreateNew(TransactionalProcessor.java:110)
> org.apache.isis.viewer.restfulobjects.viewer.webmodule.IsisRestfulObjectsInteractionFilter.lambda$doFilter$3(IsisRestfulObjectsInteractionFilter.java:386)
> org.apache.isis.core.runtimeservices.session.InteractionServiceDefault.runInternal(InteractionServiceDefault.java:329)
> org.apache.isis.core.runtimeservices.session.InteractionServiceDefault.run(InteractionServiceDefault.java:272)
> org.apache.isis.viewer.restfulobjects.viewer.webmodule.IsisRestfulObjectsInteractionFilter.doFilter(IsisRestfulObjectsInteractionFilter.java:383)
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
> org.apache.isis.core.webapp.modules.logonlog.IsisLogOnExceptionFilter.doFilter(IsisLogOnExceptionFilter.java:60)
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
> org.springframework.web.filter.CorsFilter.doFilterInternal(CorsFilter.java:91)
> org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117)
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
> org.springframework.web.filter.FormContentFilter.doFilterInternal(FormContentFilter.java:93)
> org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117)
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
> org.springframework.boot.actuate.metrics.web.servlet.WebMvcMetricsFilter.doFilterInternal(WebMvcMetricsFilter.java:96)
> org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117)
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
> org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:201)
> org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117)
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:197)
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97)
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:540)
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135)
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78)
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:357)
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:382)
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:895)
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1732)
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
> org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)
> org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> java.base/java.lang.Thread.run(Thread.java:834)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to