[
https://issues.apache.org/jira/browse/ISIS-2982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511248#comment-17511248
]
ASF subversion and git services commented on ISIS-2982:
-------------------------------------------------------
Commit bda11958981d48906219d2dba3b0928326fc78e8 in isis's branch
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=bda1195 ]
ISIS-2982: fixes PoReader empty lines check
> I18n does not load translation files
> ------------------------------------
>
> Key: ISIS-2982
> URL: https://issues.apache.org/jira/browse/ISIS-2982
> Project: Isis
> Issue Type: Bug
> Components: Isis Core
> Affects Versions: 2.0.0-M7
> Reporter: Miklós Győrfi
> Assignee: Andi Huber
> Priority: Major
> Fix For: 2.0.0-RC1
>
>
> PoReader does not check ALL translation candidates.
> In PoReader.readPoElseNull(final Locale locale)
> {code:java}
> for (final String candidate : candidates) {
> final List<String> lines = readUrl(candidate);
> if(lines != null) {
> return lines;
> }
> } {code}
> always returns at the first candidate, regardless of existing of the
> file/resource, as readUrl never returns null, because readUrl is a stream
> collect. I think it should carry on loading resources when lines == null ||
> lines.size() == 0.
> If I had translation_hu.po, it was the last candidate, it was never loaded.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
