andi-huber commented on code in PR #1027:
URL: https://github.com/apache/isis/pull/1027#discussion_r929524111
##########
core/metamodel/src/main/java/org/apache/isis/core/metamodel/services/appfeat/ApplicationFeatureRepositoryDefault.java:
##########
@@ -64,19 +68,23 @@
import lombok.extern.log4j.Log4j2;
@Service
-@Named("isis.metamodel.ApplicationFeatureRepositoryDefault")
+@Named(ApplicationFeatureRepositoryDefault.LOGICAL_TYPE_NAME)
@Log4j2
public class ApplicationFeatureRepositoryDefault
implements ApplicationFeatureRepository, MetamodelListener {
+ static final String LOGICAL_TYPE_NAME = IsisModuleCoreMetamodel.NAMESPACE
+ ".ApplicationFeatureRepositoryDefault";
+
// -- caches
private Map<String, ApplicationFeatureId> featureIdentifiersByName;
final SortedMap<ApplicationFeatureId, ApplicationFeature>
namespaceFeatures = _Maps.newTreeMap();
private final SortedMap<ApplicationFeatureId, ApplicationFeature>
typeFeatures = _Maps.newTreeMap();
+ private final SortedMap<LogicalType, ApplicationFeatureId>
typeFeatureIdByLogicalType = _Maps.newTreeMap();
private final SortedMap<ApplicationFeatureId, ApplicationFeature>
memberFeatures = _Maps.newTreeMap();
private final SortedMap<ApplicationFeatureId, ApplicationFeature>
propertyFeatures = _Maps.newTreeMap();
private final SortedMap<ApplicationFeatureId, ApplicationFeature>
collectionFeatures = _Maps.newTreeMap();
private final SortedMap<ApplicationFeatureId, ApplicationFeature>
actionFeatures = _Maps.newTreeMap();
+ private final SortedMap<String, List<ApplicationFeature>>
memberFeaturesByLogicalTypeName = _Maps.newTreeMap();
Review Comment:
this is a multi-map ... I think I should add a **TreeMap of ArrayLists**
variant to `_MultiMaps`, which we currently don't have it seems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
