andi-huber commented on code in PR #1086: URL: https://github.com/apache/isis/pull/1086#discussion_r963857558
########## core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/collparam/semantics/CollectionSemantics.java: ########## @@ -18,119 +18,51 @@ */ package org.apache.isis.core.metamodel.facets.collparam.semantics; -import java.util.Collection; -import java.util.List; -import java.util.Queue; -import java.util.Set; -import java.util.SortedSet; +import java.lang.reflect.Method; +import java.lang.reflect.Parameter; -import org.apache.isis.commons.collections.Can; +import org.apache.isis.core.config.progmodel.ProgrammingModelConstants; -public enum CollectionSemantics { +public interface CollectionSemantics { - ARRAY(true), + // -- FACTORIES - COLLECTION_INTERFACE(true), Review Comment: reinstate enum names via toString for metamodel export; or replace by entirely by CollectionType from ProgrammingModelConstants -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@isis.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org