[ 
http://issues.apache.org/jira/browse/JCR-476?page=comments#action_12420627 ] 

Marcel Reutegger commented on JCR-476:
--------------------------------------

I suggest we also remove or at least deprecate the methods 
NamespaceResolver.getQName() and NamespaceResolver.getJCRName(). I introduced 
them to support caching of QName <-> JCR Name conversion. At that time the 
NamespaceResolver seemed to be the only place where to put the cache. Now that 
we have a NameFormat and PathFormat we should move the caching mechanism in a 
subclass of Name/PathFormat. IMO this makes more sense.

> Remove recently added getJCRPath()/getQPath() from NamespaceResolver
> --------------------------------------------------------------------
>
>          Key: JCR-476
>          URL: http://issues.apache.org/jira/browse/JCR-476
>      Project: Jackrabbit
>         Type: Improvement

>     Versions: 1.1
>     Reporter: Tobias Bocanegra
>     Assignee: Tobias Bocanegra
>     Priority: Minor

>
> issue JCR-473 added 2 new methods to NamespaceResolver: 
>     public Path getQPath(String jcrPath) throws MalformedPathException;
>     public String getJCRPath(Path qPath) throws NoPrefixDeclaredException;
> which do not belong here, since the NamespaceResolver has nothing to do with 
> paths. suggest to remove them.
> further is the naming of the QName related methods a bit vague. suggest to 
> rename them to:
>    QName parseName(String jcrName)
>    String formatName(QName qName)
> (although they do not belong here either, but helps to leverage evt. caching 
> namespace resolvers).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to