[ 
http://issues.apache.org/jira/browse/JCR-491?page=comments#action_12423568 ] 
            
Marcel Reutegger commented on JCR-491:
--------------------------------------

Hi Nicolas,

Thank you for the proposal.

The patch introduces a check for supertype names that have the prefix 'jcr'. I 
don't see why this is necessary. Afaik there are only predefined node types 
with prefixes 'nt' and 'mix'.

Is this some kind of left over or why is it necessary?

Other than that the patch looks fine.

> TCK: PredefinedNodeTypeTest does not allow additions to the predefined node 
> types hierarchy
> -------------------------------------------------------------------------------------------
>
>                 Key: JCR-491
>                 URL: http://issues.apache.org/jira/browse/JCR-491
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: test
>         Environment: TCK from SVN revision 421925
>            Reporter: Nicolas Pombourcq
>         Assigned To: Marcel Reutegger
>
> As explained in section 6.7.22.2 (page 147) of the JSR 170 specification, an 
> implementation is allowed to customize a predefined noe type definition with 
> additional supertypes. The tests in PredefinedNodeTypeTest do not account for 
> that and expect an exact match with the predefined node types.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to