[
http://issues.apache.org/jira/browse/JCR-569?page=comments#action_12435349 ]
Jukka Zitting commented on JCR-569:
-----------------------------------
The patch still fails. The failing tests are in org.apache.jackrabbit.test.api.
I'm getting:
[junit] Tests run: 584, Failures: 0, Errors: 14, Time elapsed: 17,734 sec
[junit] [ERROR] TEST org.apache.jackrabbit.test.api.TestAll FAILED
You can run the unit tests individually, but I'd really recommend you to use
"maven jar" (or even "maven clean jar") at least as the final verification step
before submitting patches. Detailed test reports get saved in
target/test-reports.
> WorkspaceImporter Refactoring
> -----------------------------
>
> Key: JCR-569
> URL: http://issues.apache.org/jira/browse/JCR-569
> Project: Jackrabbit
> Issue Type: Improvement
> Reporter: Nicolas Toper
> Attachments: GenericImporter.patch, SysViewImporter.patch,
> WorkspaceImporter.patch, WorkspaceImporter.patch
>
>
> Hi,
> As you know, I have run into an issue with the backup tool using the
> WorkspaceImporter. I ended up copy/pasting large body of code since the
> current WorkspaceImporter was not flexible enough for my use (in my class
> called SysViewImporter). This solution was perfectly valid for Google SoC (a
> lot of time constraints) but unacceptable in the long run for any project (we
> hate large body of duplicate code :p).
> Also, some issues have been raised with this class (i.e. jcr:root
> importation, allowsSameNameSiblings issue).
> Overall I feel this class is circumvoluted and really hard to understand.
> For instance, the current code contains at most 5 imbricated if and uses a
> lot of different ways to pass information (stacks, objects set on null).
> I tried to refactor my SysViewImporter and the WorkspaceImporter but it
> implies a new code for the WorkspaceImporter and the SysViewImporter. Here is
> its skeleton! I first wanted to gather the community feedback before stepping
> in. I tried moving all "work code" away from the startNode method and
> reorganise it for readilibility.
> Please give me your feedback.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
