[ http://issues.apache.org/jira/browse/JCR-691?page=comments#action_12461170 ] Jukka Zitting commented on JCR-691: -----------------------------------
> But this change may break some code, no? Yes, it's a change to the public API of jackrabbit-jcr-commons, and thus can lead to some things breaking. This is the reason why I didn't just commit the change. I don't think there are many (any?) cases where BaseException is caught instead of NameException or one of the more specific subclasses, thus this change shouldn't affect too many things. But please comment if there are cases where this would be troublesome. > Let NameException extend RepositoryException > -------------------------------------------- > > Key: JCR-691 > URL: http://issues.apache.org/jira/browse/JCR-691 > Project: Jackrabbit > Issue Type: Improvement > Components: core > Reporter: Jukka Zitting > Priority: Minor > Fix For: 1.3 > > Attachments: NameException.patch > > > Since the NameExceptions (IllegalNameException, UnknownPrefixException, etc.) > are typically thrown when parsing or formatting JCR names at the JCR API > level, it would make sense for the NameException class to extend > RepositoryException instead of the internal BaseException. This idea is > supported by the fact that the majority of cases where NameExceptions are > encountered simply rethrow the exceptions wrapped inside RepositoryException > instances. Making NameException extend RepositoryException would reduce the > amount of try-catch blocks and wrapped exceptions. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
