[
https://issues.apache.org/jira/browse/JCR-556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Toper updated JCR-556:
------------------------------
Attachment: VisitorPattern22022007.patch
Hello,
Thanks for your comment.
VisitorPattern22022007.patch implements nearly all of your remarks.
I didn't change the code flow. IMO both ways has drawbacks. I feel the code is
still clear because it is really simple. Since it is easy to fix later, I
propose to do it later if we feel the need.
Nico
> Refactoring of the BackupTool
> -----------------------------
>
> Key: JCR-556
> URL: https://issues.apache.org/jira/browse/JCR-556
> Project: Jackrabbit
> Issue Type: Improvement
> Reporter: Nicolas Toper
> Priority: Minor
> Attachments: BIO.patch, patch-backup-040906.txt,
> patch-jr-010906-NodeVersionHistoriesUpdatableStateManager.txt,
> patch-jr-010906-PropInfo.txt, patch-jr-010906-RepositoryImpl.txt,
> patch-jr-010906-SysViewImporter.txt, patch-jr-010906-VersionManagerImpl.txt,
> PropInfo.patch, VisitorPattern200207.patch, VisitorPattern22022007.patch
>
>
> The BackupTool has still some refactoring to perform. I will propose the
> patch on this new issue since we cannot change the JCR-442 (Google wants to
> see a place where all the Google SoC work is).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
