[ 
https://issues.apache.org/jira/browse/JCR-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485340
 ] 

Jukka Zitting commented on JCR-789:
-----------------------------------

Sounds like a correct change to me.

BTW, is there even a need for the INDEX_UNDEFINED case? In other words, could 
we always normalize path components to internally always have an index that is 
>= 1? If the index is 1, then the "[n]" part would be skipped during string 
serialization.

Another note about this issue, does the comparison failure cause a regression 
against documented behaviour? If not, then I'd categorize this as an 
improvement rather than a bug.

> PathElement.equals doesn't handle INDEX_UNDEFINED
> -------------------------------------------------
>
>                 Key: JCR-789
>                 URL: https://issues.apache.org/jira/browse/JCR-789
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: core
>            Reporter: Julian Reschke
>            Priority: Minor
>         Attachments: jcr789.diff.txt
>
>
> PathElement (and therefore Path) comparisons fail when INDEX_UNDEFINED is 
> used (it's treated differently from INDEX_DEFAULT).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to