[
https://issues.apache.org/jira/browse/JCR-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498485
]
Michael Neale commented on JCR-863:
-----------------------------------
Yes, I think it could have the same issues. Looking over the JDK code and the
comments, it seems that this locking is really up to the OS/platform to decide
exactly how to do (ie its possible to ignore it) - at least thats my reading,
so JCR-933 could be an issue. As for JCR-912, I wasn't quite able to understand
it.
I grant the license to the ASF (my oversight ! sorry !).
The change to the DISABLE_LOCKS is also an oversight, I was turning off the
system property when debugging, yes it should be left as it. I will try and
upload a new patch soon.
> Patch to use FileLock for locking instead of empty file
> -------------------------------------------------------
>
> Key: JCR-863
> URL: https://issues.apache.org/jira/browse/JCR-863
> Project: Jackrabbit
> Issue Type: Improvement
> Components: query
> Reporter: Michael Neale
> Fix For: 1.4
>
> Attachments: FSDirectory.patch
>
>
> The FSDirectory uses File.createNewFile to effectively lock a directory (in
> makeLock), yet the Java Spec says explcitly not to use it for this purpose,
> and instead use FileLock from nio.
> The attached patch shows how this is/could be done (change is internal to the
> makeLock method only, and functionally equivalent, the same tests apply).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
