hi marcel,
On 5/30/07, Marcel May <[EMAIL PROTECTED]> wrote:
Hi Stefan!
Thanks alot, that was fast.
Another question - the wiki pages
(http://wiki.apache.org/jackrabbit/JackRabbitOnTomcat) mention
org.apache.jackrabbit.core.fs.db.JNDIOracleDatabaseFileSystem and
org.apache.jackrabbit.core.state.db.JNDIOracleDatabasePersistenceManager .
i don't know anything about those classes. personally i don't think it's
a good idea to use externally managed datasources in jackrabbit's
persistence layer. jackrabbit needs absolute and exclusive control
over the underlying database connection. jackrabbit is not a
'database application' but infrastucture with special requirements
wrt its persistence layer.
It seems theses classes do not exist in the trunk. Would you accept
those implementations, or was there a decision against these
implementations? I could open an issue for these and provide a patch, too.
feel free to do so if you don't agree with my rationale.
cheers
stefan
Cheers,
Marcel
Stefan Guggisberg (JIRA) wrote:
> [
https://issues.apache.org/jira/browse/JCR-951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
>
> Stefan Guggisberg resolved JCR-951.
> -----------------------------------
>
> Resolution: Fixed
>
> thanks for the patch! fixed as suggested and applied same change to
DatabaseFileSystem & BundleDbPersistenceManager as well.
>
> fixed in svn r542831.
>
>
>> OracleFileSystem uses getClass().getResourceAsStream to load schema file
>> ------------------------------------------------------------------------
>>
>> Key: JCR-951
>> URL: https://issues.apache.org/jira/browse/JCR-951
>> Project: Jackrabbit
>> Issue Type: Improvement
>> Components: core
>> Affects Versions: 1.3.1
>> Reporter: Marcel May
>> Assignee: Stefan Guggisberg
>> Priority: Minor
>> Fix For: 1.3.1
>>
>> Attachments: jackrabbit.542562.patch.txt
>>
>>
>> org.apache.jackrabbit.core.fs.db.OracleFileSystem loads the schema via
getClass().getResourceAsStream(...).
>> This makes it impossible to extend the class without either copying the
schema ddl file, or overwriting checkSchema(...),
>> as the schema file is not accessible.
>> The solution is to use OracleFilesystem.class.getResourceAsStream(...).
>> See JCR-595 which fixed this already for
org.apache.jackrabbit.core.persistence.db.DatabasePersistenceManager.
>>
>
>
