[ 
https://issues.apache.org/jira/browse/JCR-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513245
 ] 

Bertrand Delacretaz commented on JCR-388:
-----------------------------------------

I'm just saying that the patch is indeed in SVN format, the only slight problem 
is that the pathnames are not relative to the jackrabbit root, for example:

--- 
C:/jprojects/eclipse/version_patch/src/main/java/org/apache/jackrabbit/server/io/DefaultIOManager.java
      (revision 556115)
+++ 
C:/jprojects/eclipse/version_patch/src/main/java/org/apache/jackrabbit/server/io/DefaultIOManager.java
      (working copy)

which should ideally be 

  
jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/server/io/DefaultIOManager.java

This happens frequently depending on people's environments, and SVN clients (I 
assume tortoise does this as well) have an option to ignore a certain number of 
path elements when appliying patches.

So in my example, "patch -p4" means "ignore C:/jprojects/eclipse/version_patch 
from the pathnames in the patch".

But apart from that the patch is IMHO fine.


> add support for RFC 3253 to the simple server
> ---------------------------------------------
>
>                 Key: JCR-388
>                 URL: https://issues.apache.org/jira/browse/JCR-388
>             Project: Jackrabbit
>          Issue Type: New Feature
>          Components: webdav
>    Affects Versions: 0.9
>            Reporter: jeremi Joslin
>            Assignee: angela
>            Priority: Minor
>         Attachments: patch_16JUL07.txt, patch_16JUL07.zip, patch_rfc3253.zip, 
> Review.txt, rfc.zip
>
>
> http://www.ietf.org/rfc/rfc3253.txt

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to