[
https://issues.apache.org/jira/browse/JCR-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518239
]
Christophe Lombart commented on JCR-998:
----------------------------------------
* I added support for the bean descriptor.
* I dropped the AnnotationObjectContentManagerImpl because we can use the
ObjectContentManagerImpl. Only the mapper is different for the annotation
support.
* I also modified the annotation attribute names. In order to avoid confusion,
it is important to use the same name as the xml file descriptors. Please make
suggestions if you think that the names are not correct. the collection
annotation has to be modify (should be done this week).
* I added more unit tests (map objects into nt:unstructured). I will add more
unit test for mapping on specific node types.
I will continue to work on this issue. I think we can add the following
improvements :
* Create an abstract mapper impl because both Mapper classes have a lot of code
in common (AnnotedObjectMapper & DigesterMapperImpl).
* The Mapper classes should not have the responsibility to create the jcr node
types. This can be done outside the mapper and it should be an optional
operation. There are certainly some use cases where node type creation is not
necessary.
* I'm just wondering how can we use the same unit tests for both approach (xml
file & annotations).
* Can we drop the annotation SuperType. This is defined in the annotation Node
(jcrSuperTypes) ?
* Add license headers
Please add your comments and feedback.
> Annotation based implementation of jackrabbit ocm
> -------------------------------------------------
>
> Key: JCR-998
> URL: https://issues.apache.org/jira/browse/JCR-998
> Project: Jackrabbit
> Issue Type: New Feature
> Components: jcr-mapping
> Reporter: Carlos Sanchez
> Assignee: Christophe Lombart
> Attachments: jackrabbit-ocm-annotation.tgz, ocm-nodemanagement.patch,
> ocm-nodemanagement.patch, ocm.patch
>
>
> we have created an annotation based implementation of jackrabbit-ocm that can
> be used instead of the digester one
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
