Re: Logging of exceptions

[Christoph Kiehl]

Christoph Kiehl wrote:

Maybe the following:
private boolean hasNonVirtualItemState(ItemId id) {
     [...]
     } catch (ItemStateException ise) {
         return false;
     }
     [...]
}

should be rewritten to:

private boolean hasNonVirtualItemState(ItemId id) {
     [...]
     } catch (NoSuchItemStateException ise) {
         return false;
     } catch (ItemStateException ise) {
         log.error(ise.getMessage(), ise);
         throw new RuntimeException(ise);
     }
     [...]
}

Well, maybe throwing a RepositoryException instead of a RuntimeException 
would be more appropriate ;)

Cheers,
Christoph