[ 
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522466
 ] 

Ard Schrijvers commented on JCR-1064:
-------------------------------------

Not closing SearchIndex.getIndexReader(), that is an ugly mistake. Correct it.

About the IndexVersion class. You want this to be a SearchIndex innerclass or a 
seperate one? 

And then, instead of 

if(newIndexFormat)

something like 

if(indexVersion.getInfo.equals("1") )  

The reasoning is that it is more flexible if we might face another indexing 
format, we can add "3" 

I you let me know, I will upload the patch (which I was doing by the way with 
Christoph's changes and almost hit post, when I saw your suggestions :-) )

> Optimize queries that check for the existence of a property
> -----------------------------------------------------------
>
>                 Key: JCR-1064
>                 URL: https://issues.apache.org/jira/browse/JCR-1064
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: indexing
>    Affects Versions: 1.3.1
>            Reporter: Ard Schrijvers
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: JCR-1064.patch
>
>
> //[EMAIL PROTECTED] is transformed into the 
> org.apache.jackrabbit.core.query.lucene.MatchAllQuery, that through the 
> MatchAllWeight uses the MatchAllScorer.  The calculateDocFilter() in 
> MatchAllScorer  does not scale and becomes slow for growing number of nodes. 
> Solution: lucene documents will get a new Field:
> public static final String PROPERTIES_SET = "_:PROPERTIES_SET".intern();
> that holds the available properties of this document. 
> NOTE: Lucene indices build without this performance improvement should still 
> work and fall back to the original implementation

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to